All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Chen Gang <gang.chen@asianux.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Tejun Heo <tj@kernel.org>, Jan Kara <jack@suse.cz>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: trace: blktrace: remove redundent memcpy() in compat_blk_trace_setup()
Date: Sun, 3 Nov 2013 11:16:39 -0700	[thread overview]
Message-ID: <20131103181639.GA14163@kernel.dk> (raw)
In-Reply-To: <20131103123647.0bae8cf6@gandalf.local.home>

On Sun, Nov 03 2013, Steven Rostedt wrote:
> A quick review of this patch looks fine to me.
> 
> Although, using ARRAY_SIZE() for a character string seems to me a bit
> over paranoid. But I'm fine with it, as it makes sure that the string
> is an array and not a pointer.
> 
> Jens,
> 
> Can you give me an Acked-by?

Thanks, but I'll just queue it up with the other block bits for 3.13.

-- 
Jens Axboe


  reply	other threads:[~2013-11-03 18:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-03 14:23 [PATCH] kernel: trace: blktrace: remove redundent memcpy() in compat_blk_trace_setup() Chen Gang
2013-11-03 17:36 ` Steven Rostedt
2013-11-03 18:16   ` Jens Axboe [this message]
2013-11-03 20:15     ` Steven Rostedt
2013-11-04  0:51       ` Chen Gang
2013-11-04  0:55   ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131103181639.GA14163@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fweisbec@gmail.com \
    --cc=gang.chen@asianux.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.