All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: improve chain name validation
Date: Sun, 3 Nov 2013 21:23:23 +0100	[thread overview]
Message-ID: <20131103202323.GA31399@localhost> (raw)
In-Reply-To: <20131005163315.GA16881@home>

On Sat, Oct 05, 2013 at 09:33:15AM -0700, Phil Oester wrote:
> As pointed out by Andrew Domaszek, iptables allows whitespace to be included in
> chain names.  This causes issues with iptables-restore, and later iptables
> actions on the chain.  Attached patch disallows whitespace, and also consolidates
> all chain name checking into a new function.
> 
> This closes netfilter bugzilla #855.

Applied, thanks Phil.

I have mangled this patch to include the ip6tables.c chunk, let me
know if you find any problem with it.

  parent reply	other threads:[~2013-11-03 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-05 16:33 [PATCH] iptables: improve chain name validation Phil Oester
2013-10-07 14:14 ` Jan Engelhardt
2013-10-08 16:08   ` Phil Oester
2013-11-03 20:23 ` Pablo Neira Ayuso [this message]
2013-11-03 22:33   ` Phil Oester

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131103202323.GA31399@localhost \
    --to=pablo@netfilter.org \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.