Re: [PATCH] iptables: spurious error in load_extension

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Oct 08, 2013 at 09:20:15AM -0700, Phil Oester wrote:
> In commit 927385017047d (iptables: improve error reporting with extension
> loading troubles), a new error message was added in an attempt to handle
> the case where a match does not support a particular protocol family. 
> For instance, attempting to use the osf match on IPv6.
> 
> Unfortunately, this error message now triggers when creating a new chain
> which has the same name as a match extension, because iptables calls
> xtables_find_target with the name of the new chain to verify it does not
> clash with an existing target.  For example:
> 
>     # iptables -N tcp
>     /usr/lib/xtables/libxt_tcp.so: no "tcp" extension found for this protocol
> 
> I attempted to resolve this by adding a new XTF flag, but that required changes
> in many different places (including -j handling).  It seems easiest just to
> remove this warning and stick with the original error message of ENOENT, even
> if less than precise.

Also applied, thanks Phil.