From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 07/19] drm/host1x: Call drm_put_dev directly instead of drm_platform_exit Date: Mon, 4 Nov 2013 10:13:32 +0100 Message-ID: <20131104091331.GF27445@ulmo.nvidia.com> References: <1383485485-8210-1-git-send-email-daniel.vetter@ffwll.ch> <1383485485-8210-8-git-send-email-daniel.vetter@ffwll.ch> <20131104091037.GE27445@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0505976491==" Return-path: Received: from mail-bk0-f41.google.com (mail-bk0-f41.google.com [209.85.214.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 50AD2112547 for ; Mon, 4 Nov 2013 01:13:35 -0800 (PST) Received: by mail-bk0-f41.google.com with SMTP id na10so2809387bkb.0 for ; Mon, 04 Nov 2013 01:13:34 -0800 (PST) In-Reply-To: <20131104091037.GE27445@ulmo.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0505976491== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O98KdSgI27dgYlM5" Content-Disposition: inline --O98KdSgI27dgYlM5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 04, 2013 at 10:10:38AM +0100, Thierry Reding wrote: > On Sun, Nov 03, 2013 at 02:31:13PM +0100, Daniel Vetter wrote: > > I'm a bit confused about how this all works wrt host1x clients, but > > this patch looks like the right thing to me. > >=20 > > Cc: Thierry Reding > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/host1x/drm/drm.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > This has been largely rewritten in the code that I submitted in my 3.13 > pull request. In fact Tegra DRM no longer uses drm_platform, but a > custom bus type to deal with the quirkiness of the multi-driver > architecture. And for what it's worth, there's a drm_host1x_exit() that actually does only drm_put_dev(), which I guess could be simplified in the way that you've done here, but I sort of liked the symmetry between an *_init()/ *_exit() pair of functions. Thierry --O98KdSgI27dgYlM5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSd2U7AAoJEN0jrNd/PrOhsDUP/2376mn/dAFOceaNiId8adpr UYsgwmIdefCYrGp0sc5PTQUh6jriy1/JOppHNo8xBYx5ISEcnCqCHT9U61GS7BkI uP4uucjtRjCeP1Q59u5fZMyLUR9ptXYBJwifmp6SCTVn/p+1ShWVdCMrgnvrxGWI UAsgy7RamJgilaI+DSxH7FigirkeUiNN2nasp2bovuNwwbW97WQEW/XZ+g+C9oZN wmntcncbMSRaj423behyfSaUcgyiF+m2VYksG9hmHF4Ndz6q+gJMFtmPWNWCtO9i 7duhs9OZk9/qOXXF92xzcZo6eIm7WDET941prKAHL4axiaYyBE69GmguxN8GSa9T VtTjNeq+G/K2a9MAs7esnzWhWrQA2I39X7n6VwrPh4f01ibPJ/AugPltcxCGbf1X ZXcdbKHCMZ2w05i4Yowy5tVzBAzR0/gd8FCuhw9BgdZmXSw4mDCguD2XQuuJWtvj o0wAuWA/grysF/wS2bNK63AEGsgvd0pLFjJPcPMSsL0RcU1DMXJXi+LciDMExN8m 5bFne6sjGouU365xEcc/j+gVBSi8FAdbXMTArd3msf+I2oRnVsqbypULtFWwSzty W+m/1mUDBiQ2bzGLSTKTNQTq8C0JpmJMP8RmtyUL6NP5bHbDE7vV7OQ/xbk/cpAa TOSiaiPYYvHaNdDwJjOg =Dp8t -----END PGP SIGNATURE----- --O98KdSgI27dgYlM5-- --===============0505976491== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0505976491==--