From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 11/19] drm: restrict the device list for shadow attached drivers Date: Mon, 4 Nov 2013 10:20:42 +0100 Message-ID: <20131104092041.GG27445@ulmo.nvidia.com> References: <1383485485-8210-1-git-send-email-daniel.vetter@ffwll.ch> <1383485485-8210-12-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1173393324==" Return-path: Received: from mail-bk0-f51.google.com (mail-bk0-f51.google.com [209.85.214.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 050A3F9EF1 for ; Mon, 4 Nov 2013 01:20:46 -0800 (PST) Received: by mail-bk0-f51.google.com with SMTP id my12so941795bkb.10 for ; Mon, 04 Nov 2013 01:20:44 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1173393324== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ulDeV4rPMk/y39in" Content-Disposition: inline --ulDeV4rPMk/y39in Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 03, 2013 at 03:14:16PM +0100, Daniel Vetter wrote: > On Sun, Nov 3, 2013 at 3:05 PM, David Herrmann wr= ote: > > On Sun, Nov 3, 2013 at 2:31 PM, Daniel Vetter = wrote: > >> There's really no need for the drm core to keep a list of all > >> devices of a given driver - the linux device model keeps perfect > >> track of this already for us. > >> > >> The exception is old legacy ums drivers using pci shadow attaching. > >> So rename the lists to make the use case clearer and rip out everything > >> else. > >> > >> v2: Rebase on top of David Herrmann's drm device register changes. > >> Also drop the bogus dev_set_drvdata for platform drivers that somehow > >> crept into the original version - drivers really should be in full > >> control of that field. > > > > You didn't really change any dev_set_drvdata, did you? And I guess you > > mean pci_set_drvdata()? I had to keep it in place in drm_pci.c as it > > has been there before my device-registration changes. However, with > > your series you added the pci_set_drvdata() everywhere yourself, so > > yes, please remove it. >=20 > That was a bogus hunk in v1 of this patch, which iirc I've never > posted onto the list anywhere. I added a platfrom_set_drvdata call, > but with the previous series to make sure that each driver has that > it's a bit redundant. >=20 > Long term, when we split up the drm init code I think the drvdata > assignment should be the driver's job. I remember submitting a patch for that a while ago. It was applied about a year ago, see commit a16d4f86019a ('drm: platform: Don't initialize driver-private data'). The issue at the time was that I needed the drvdata for other purposes and drm_platform_init() kept overwriting it, which had me confused for days. Thierry --ulDeV4rPMk/y39in Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSd2bpAAoJEN0jrNd/PrOhi3MP/jrcFwMGOOqFfkbBs7ZW0k3u Nu1TN/LOEqrVZlC9MJxYnBNi8+AnviSNFQ7b84FAsToBf+aEi5s4Rn/K04yUbJO/ xgavsPMGa50ueOfoIGaVHZKxu8JUVQzgbXQ5tNklS37py8jz67rK6oAKOfhgK9Io s7NA0gSYGnvLdOvXpre3S7AgGJjUH6CYu2BnzjLpCqkVNexSyHa7iRH5hBO13xgl 4MoO0voh5rAihT6g5Rg+bnVsZb+fMl/3kHgFXAoFCWx+6X3kcUKKiVYhiSVOwN1j tsXXh5LNMjhzyx/EGD9LMazoEFCrbFHMd0035bY9JXz45ybK/upOgNsqV8pvefKA VfMixh/oUfQowX/RKOtc5mRFUBKRrHh3Vg2qjGKPNHzscMasgX7+BJ03rKPMuIxU rP3/MQyuqbypBqS+iwNZ81VBsNKe9LJUpvQI/w3j4EBbYEFhcM+xOdwuy46pnAVX e7UUoG2VPu2efk0ANTJIDfqBDgU4dmnIzk8QfZA8Pew9F6KtWoviCMOpnjNiEEUC kTkOxVK6N4XmRfM7ciVF6nBGE7sFVQc734EMfFWAMZgP99ZpsAqvLP+ttCwSGBs1 V8Zinvc64ByqA+oqLJr38EXJgfRuPJ0MaSkO/omDcngmsdj0iVPlAx9eysD6jQmh ovxBMjVZyVLLDKiw8O88 =+6mJ -----END PGP SIGNATURE----- --ulDeV4rPMk/y39in-- --===============1173393324== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1173393324==--