From: Ondrej Zary <linux@rainbow-software.org>
To: Aldo Iljazi <mail@aldo.io>
Cc: marek.belisko@gmail.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ft1000: fixed a few styling issues
Date: Mon, 4 Nov 2013 13:32:20 +0100 [thread overview]
Message-ID: <201311041332.21209.linux@rainbow-software.org> (raw)
In-Reply-To: <1383567322-22879-1-git-send-email-mail@aldo.io>
On Monday 04 November 2013, Aldo Iljazi wrote:
> Fixed the following styling issues:
>
> Line 30:
> Removed space before open square bracket '['
>
> Lines 31 to 155:
> Moved the commas that were in the start of the lines, to the end of the
> lines. Inserted spaces after the commas.
> Inserted a one tab indentation to each line.
>
> Signed-off-by: Aldo Iljazi <mail@aldo.io>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/boot.h | 252
> ++++++++++++++-------------- 1 file changed, 126 insertions(+), 126
> deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> b/drivers/staging/ft1000/ft1000-pcmcia/boot.h index 9dce54e..915165e 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> @@ -27,132 +27,132 @@
> #define _BOOTH_
>
> // Official bootloader
> -static unsigned char bootimage [] = {
> -0x00,0x00,0x01,0x5E,0x00,0x00
> -,0x00,0x00,0x00,0x00,0x02,0xD7
> -,0x00,0x00,0x01,0x5E,0x46,0xB3
> -,0xE6,0x02,0x00,0x98,0xE6,0x8C
> -,0x00,0x98,0xFB,0x92,0xFF,0xFF
> -,0x98,0xFB,0x94,0xFF,0xFF,0x98
> -,0xFB,0x06,0x08,0x00,0x98,0xFB
> -,0x96,0x84,0x00,0x98,0xFB,0x08
> -,0x1C,0x00,0x98,0xFB,0x51,0x25
> -,0x10,0x1C,0x00,0xE6,0x51,0x01
> -,0x07,0xFD,0x4C,0xFF,0x20,0xF5
> -,0x51,0x02,0x20,0x08,0x00,0x4C
> -,0xFF,0x20,0x3C,0x00,0xC0,0x64
> -,0x98,0xC0,0x66,0x98,0xC0,0x68
> -,0x98,0xC0,0x6A,0x98,0xC0,0x6C
> -,0x98,0x90,0x08,0x90,0x09,0x90
> -,0x0A,0x90,0x0B,0x90,0x0C,0x90
> -,0x0D,0x90,0x0E,0x90,0x0F,0x90
> -,0x04,0x90,0x06,0xFB,0x51,0x22
> -,0x16,0x08,0x03,0xFB,0x51,0x52
> -,0x16,0x08,0x04,0xFB,0x51,0x24
> -,0x2B,0x08,0x06,0xFB,0x51,0x54
> -,0x2B,0x08,0x07,0xFB,0x51,0x24
> -,0x2B,0x08,0x09,0xFB,0x51,0x54
> -,0x2B,0x08,0x0A,0xFB,0x51,0x12
> -,0x16,0x08,0x0C,0xFB,0x51,0x52
> -,0x16,0x08,0x0D,0x78,0x00,0x00
> -,0x00,0x16,0x00,0x00,0xEC,0x31
> -,0xAE,0x00,0x00,0x81,0x4C,0x0F
> -,0xE6,0x43,0xFF,0xEC,0x31,0x4E
> -,0x00,0x00,0x91,0xEC,0x31,0xAE
> -,0x00,0x00,0x91,0x4C,0x0F,0xE6
> -,0x43,0xFF,0xEC,0x31,0x5E,0x00
> -,0x00,0xA1,0xEB,0x31,0x08,0x00
> -,0x00,0xA6,0xEB,0x31,0x08,0x00
> -,0x00,0xAC,0x3C,0x00,0xEB,0x31
> -,0x08,0x00,0x00,0xA8,0x76,0xFE
> -,0xFE,0x08,0xEB,0x31,0x08,0x20
> -,0x00,0x00,0x76,0xFF,0xFF,0x18
> -,0xED,0x31,0x08,0x20,0x00,0x00
> -,0x26,0x10,0x04,0x10,0xF5,0x3C
> -,0x01,0x3C,0x00,0x08,0x01,0x12
> -,0x3C,0x11,0x3C,0x00,0x08,0x01
> -,0x0B,0x08,0x00,0x6D,0xEC,0x31
> -,0xAE,0x20,0x00,0x06,0xED,0x4D
> -,0x08,0x00,0x00,0x67,0x80,0x6F
> -,0x00,0x01,0x0B,0x6F,0x00,0x02
> -,0x2E,0x76,0xEE,0x01,0x48,0x06
> -,0x01,0x39,0xED,0x4D,0x18,0x00
> -,0x02,0xED,0x4D,0x08,0x00,0x04
> -,0x14,0x06,0xA4,0xED,0x31,0x22
> -,0x00,0x00,0xAC,0x76,0xEE,0x07
> -,0x48,0x6D,0x22,0x01,0x1E,0x08
> -,0x01,0x58,0xEB,0x31,0x08,0x00
> -,0x00,0xAC,0x06,0xFF,0xBA,0x3C
> -,0x00,0xEB,0x31,0x08,0x20,0x00
> -,0x04,0x3C,0x30,0xEB,0x31,0x08
> -,0x20,0x00,0x02,0x3C,0x10,0xEB
> -,0x31,0x08,0x20,0x00,0x00,0xED
> -,0x31,0x08,0x20,0x00,0x00,0x04
> -,0x10,0xF7,0xED,0x31,0x08,0x00
> -,0x00,0xA2,0x91,0x00,0x9C,0x3C
> -,0x80,0xEB,0x31,0x08,0x20,0x00
> -,0x04,0x3C,0x20,0xEB,0x31,0x08
> -,0x20,0x00,0x02,0x3C,0x10,0xEB
> -,0x31,0x08,0x20,0x00,0x00,0xED
> -,0x31,0x08,0x20,0x00,0x00,0x04
> -,0x10,0xF7,0xED,0x31,0x08,0x20
> -,0x00,0x04,0x42,0x10,0x90,0x08
> -,0xEC,0x31,0xAE,0x20,0x00,0x06
> -,0xA4,0x41,0x08,0x00,0xB6,0xED
> -,0x41,0x28,0x7D,0xFF,0xFF,0x22
> -,0xB3,0x40,0x98,0x2A,0x32,0xEB
> -,0x41,0x28,0xB4,0x43,0xFC,0x05
> -,0xFF,0xE6,0xA0,0x31,0x20,0x00
> -,0x06,0xEB,0x31,0x08,0x20,0x00
> -,0x04,0x3C,0x20,0xEB,0x31,0x08
> -,0x20,0x00,0x02,0x3C,0x10,0xEB
> -,0x31,0x08,0x20,0x00,0x00,0xED
> -,0x31,0x08,0x20,0x00,0x00,0x04
> -,0x10,0xF7,0xED,0x31,0x08,0x20
> -,0x00,0x04,0x42,0x10,0x90,0x08
> -,0xEC,0x31,0xAE,0x20,0x00,0x06
> -,0xA4,0x41,0x08,0x00,0x68,0xED
> -,0x41,0x28,0x7D,0xFF,0xFF,0x22
> -,0xB3,0x40,0x98,0x2A,0x32,0xEB
> -,0x41,0x28,0xB4,0x43,0xFC,0x05
> -,0xFF,0xE6,0x48,0x04,0xEB,0x31
> -,0x08,0x20,0x00,0x04,0xEB,0x31
> -,0x18,0x20,0x00,0x02,0x3C,0x11
> -,0xEB,0x31,0x18,0x20,0x00,0x00
> -,0xED,0x31,0x08,0x20,0x00,0x00
> -,0x04,0x10,0xF7,0xED,0x31,0x08
> -,0x20,0x00,0x02,0x66,0x00,0x6F
> -,0x00,0x01,0x16,0x76,0xEE,0x06
> -,0x48,0x4A,0x1E,0x48,0x04,0xED
> -,0x31,0x08,0x20,0x00,0x04,0xEB
> -,0x31,0x08,0x00,0x00,0xA4,0x48
> -,0x04,0xED,0x31,0x08,0x20,0x00
> -,0x04,0xEB,0x31,0x08,0x00,0x00
> -,0xA2,0x48,0x04,0x20,0x20,0x4A
> -,0x7C,0x46,0x82,0x50,0x05,0x50
> -,0x15,0xB5,0x1E,0x98,0xED,0x31
> -,0x08,0x00,0x00,0xA8,0x10,0x47
> -,0x3B,0x2C,0x01,0xDB,0x40,0x11
> -,0x98,0xC1,0x1E,0x98,0x10,0x07
> -,0x30,0xF9,0x40,0x07,0x18,0x98
> -,0x2A,0x10,0xEB,0x31,0x08,0x00
> -,0x00,0xA8,0xA4,0x1E,0x98,0xBB
> -,0x1E,0x98,0x50,0x14,0x50,0x04
> -,0x46,0x83,0x48,0x04,0x02,0x01
> -,0x00,0x50,0x05,0x50,0x15,0x10
> -,0x87,0x3F,0x90,0x2B,0x18,0x01
> -,0x00,0xC0,0x31,0x00,0x00,0xAE
> -,0xDF,0x41,0x00,0x08,0x00,0x1A
> -,0x42,0x11,0x67,0x01,0xDF,0x41
> -,0x02,0x08,0x00,0x10,0x42,0x11
> -,0x62,0x01,0xB4,0x43,0x4A,0x68
> -,0x50,0x14,0x50,0x04,0x24,0x10
> -,0x48,0x04,0xF2,0x31,0x00,0x01
> -,0x00,0x00,0xAE,0xF6,0x31,0x00
> -,0x01,0x00,0x00,0xAE,0x62,0xE4
> -,0xE5,0x61,0x04,0x48,0x04,0xE5
> -,0x63,0x05,0x48,0x04,0x20,0x20
> -,0x00,0x00,0x00,0x00
> +static unsigned char bootimage[] = {
> + 0x00, 0x00, 0x01, 0x5E, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x02, 0xD7,
> + 0x00, 0x00, 0x01, 0x5E, 0x46, 0xB3,
> + 0xE6, 0x02, 0x00, 0x98, 0xE6, 0x8C,
> + 0x00, 0x98, 0xFB, 0x92, 0xFF, 0xFF,
> + 0x98, 0xFB, 0x94, 0xFF, 0xFF, 0x98,
> + 0xFB, 0x06, 0x08, 0x00, 0x98, 0xFB,
> + 0x96, 0x84, 0x00, 0x98, 0xFB, 0x08,
> + 0x1C, 0x00, 0x98, 0xFB, 0x51, 0x25,
> + 0x10, 0x1C, 0x00, 0xE6, 0x51, 0x01,
> + 0x07, 0xFD, 0x4C, 0xFF, 0x20, 0xF5,
> + 0x51, 0x02, 0x20, 0x08, 0x00, 0x4C,
> + 0xFF, 0x20, 0x3C, 0x00, 0xC0, 0x64,
> + 0x98, 0xC0, 0x66, 0x98, 0xC0, 0x68,
> + 0x98, 0xC0, 0x6A, 0x98, 0xC0, 0x6C,
> + 0x98, 0x90, 0x08, 0x90, 0x09, 0x90,
> + 0x0A, 0x90, 0x0B, 0x90, 0x0C, 0x90,
> + 0x0D, 0x90, 0x0E, 0x90, 0x0F, 0x90,
> + 0x04, 0x90, 0x06, 0xFB, 0x51, 0x22,
> + 0x16, 0x08, 0x03, 0xFB, 0x51, 0x52,
> + 0x16, 0x08, 0x04, 0xFB, 0x51, 0x24,
> + 0x2B, 0x08, 0x06, 0xFB, 0x51, 0x54,
> + 0x2B, 0x08, 0x07, 0xFB, 0x51, 0x24,
> + 0x2B, 0x08, 0x09, 0xFB, 0x51, 0x54,
> + 0x2B, 0x08, 0x0A, 0xFB, 0x51, 0x12,
> + 0x16, 0x08, 0x0C, 0xFB, 0x51, 0x52,
> + 0x16, 0x08, 0x0D, 0x78, 0x00, 0x00,
> + 0x00, 0x16, 0x00, 0x00, 0xEC, 0x31,
> + 0xAE, 0x00, 0x00, 0x81, 0x4C, 0x0F,
> + 0xE6, 0x43, 0xFF, 0xEC, 0x31, 0x4E,
> + 0x00, 0x00, 0x91, 0xEC, 0x31, 0xAE,
> + 0x00, 0x00, 0x91, 0x4C, 0x0F, 0xE6,
> + 0x43, 0xFF, 0xEC, 0x31, 0x5E, 0x00,
> + 0x00, 0xA1, 0xEB, 0x31, 0x08, 0x00,
> + 0x00, 0xA6, 0xEB, 0x31, 0x08, 0x00,
> + 0x00, 0xAC, 0x3C, 0x00, 0xEB, 0x31,
> + 0x08, 0x00, 0x00, 0xA8, 0x76, 0xFE,
> + 0xFE, 0x08, 0xEB, 0x31, 0x08, 0x20,
> + 0x00, 0x00, 0x76, 0xFF, 0xFF, 0x18,
> + 0xED, 0x31, 0x08, 0x20, 0x00, 0x00,
> + 0x26, 0x10, 0x04, 0x10, 0xF5, 0x3C,
> + 0x01, 0x3C, 0x00, 0x08, 0x01, 0x12,
> + 0x3C, 0x11, 0x3C, 0x00, 0x08, 0x01,
> + 0x0B, 0x08, 0x00, 0x6D, 0xEC, 0x31,
> + 0xAE, 0x20, 0x00, 0x06, 0xED, 0x4D,
> + 0x08, 0x00, 0x00, 0x67, 0x80, 0x6F,
> + 0x00, 0x01, 0x0B, 0x6F, 0x00, 0x02,
> + 0x2E, 0x76, 0xEE, 0x01, 0x48, 0x06,
> + 0x01, 0x39, 0xED, 0x4D, 0x18, 0x00,
> + 0x02, 0xED, 0x4D, 0x08, 0x00, 0x04,
> + 0x14, 0x06, 0xA4, 0xED, 0x31, 0x22,
> + 0x00, 0x00, 0xAC, 0x76, 0xEE, 0x07,
> + 0x48, 0x6D, 0x22, 0x01, 0x1E, 0x08,
> + 0x01, 0x58, 0xEB, 0x31, 0x08, 0x00,
> + 0x00, 0xAC, 0x06, 0xFF, 0xBA, 0x3C,
> + 0x00, 0xEB, 0x31, 0x08, 0x20, 0x00,
> + 0x04, 0x3C, 0x30, 0xEB, 0x31, 0x08,
> + 0x20, 0x00, 0x02, 0x3C, 0x10, 0xEB,
> + 0x31, 0x08, 0x20, 0x00, 0x00, 0xED,
> + 0x31, 0x08, 0x20, 0x00, 0x00, 0x04,
> + 0x10, 0xF7, 0xED, 0x31, 0x08, 0x00,
> + 0x00, 0xA2, 0x91, 0x00, 0x9C, 0x3C,
> + 0x80, 0xEB, 0x31, 0x08, 0x20, 0x00,
> + 0x04, 0x3C, 0x20, 0xEB, 0x31, 0x08,
> + 0x20, 0x00, 0x02, 0x3C, 0x10, 0xEB,
> + 0x31, 0x08, 0x20, 0x00, 0x00, 0xED,
> + 0x31, 0x08, 0x20, 0x00, 0x00, 0x04,
> + 0x10, 0xF7, 0xED, 0x31, 0x08, 0x20,
> + 0x00, 0x04, 0x42, 0x10, 0x90, 0x08,
> + 0xEC, 0x31, 0xAE, 0x20, 0x00, 0x06,
> + 0xA4, 0x41, 0x08, 0x00, 0xB6, 0xED,
> + 0x41, 0x28, 0x7D, 0xFF, 0xFF, 0x22,
> + 0xB3, 0x40, 0x98, 0x2A, 0x32, 0xEB,
> + 0x41, 0x28, 0xB4, 0x43, 0xFC, 0x05,
> + 0xFF, 0xE6, 0xA0, 0x31, 0x20, 0x00,
> + 0x06, 0xEB, 0x31, 0x08, 0x20, 0x00,
> + 0x04, 0x3C, 0x20, 0xEB, 0x31, 0x08,
> + 0x20, 0x00, 0x02, 0x3C, 0x10, 0xEB,
> + 0x31, 0x08, 0x20, 0x00, 0x00, 0xED,
> + 0x31, 0x08, 0x20, 0x00, 0x00, 0x04,
> + 0x10, 0xF7, 0xED, 0x31, 0x08, 0x20,
> + 0x00, 0x04, 0x42, 0x10, 0x90, 0x08,
> + 0xEC, 0x31, 0xAE, 0x20, 0x00, 0x06,
> + 0xA4, 0x41, 0x08, 0x00, 0x68, 0xED,
> + 0x41, 0x28, 0x7D, 0xFF, 0xFF, 0x22,
> + 0xB3, 0x40, 0x98, 0x2A, 0x32, 0xEB,
> + 0x41, 0x28, 0xB4, 0x43, 0xFC, 0x05,
> + 0xFF, 0xE6, 0x48, 0x04, 0xEB, 0x31,
> + 0x08, 0x20, 0x00, 0x04, 0xEB, 0x31,
> + 0x18, 0x20, 0x00, 0x02, 0x3C, 0x11,
> + 0xEB, 0x31, 0x18, 0x20, 0x00, 0x00,
> + 0xED, 0x31, 0x08, 0x20, 0x00, 0x00,
> + 0x04, 0x10, 0xF7, 0xED, 0x31, 0x08,
> + 0x20, 0x00, 0x02, 0x66, 0x00, 0x6F,
> + 0x00, 0x01, 0x16, 0x76, 0xEE, 0x06,
> + 0x48, 0x4A, 0x1E, 0x48, 0x04, 0xED,
> + 0x31, 0x08, 0x20, 0x00, 0x04, 0xEB,
> + 0x31, 0x08, 0x00, 0x00, 0xA4, 0x48,
> + 0x04, 0xED, 0x31, 0x08, 0x20, 0x00,
> + 0x04, 0xEB, 0x31, 0x08, 0x00, 0x00,
> + 0xA2, 0x48, 0x04, 0x20, 0x20, 0x4A,
> + 0x7C, 0x46, 0x82, 0x50, 0x05, 0x50,
> + 0x15, 0xB5, 0x1E, 0x98, 0xED, 0x31,
> + 0x08, 0x00, 0x00, 0xA8, 0x10, 0x47,
> + 0x3B, 0x2C, 0x01, 0xDB, 0x40, 0x11,
> + 0x98, 0xC1, 0x1E, 0x98, 0x10, 0x07,
> + 0x30, 0xF9, 0x40, 0x07, 0x18, 0x98,
> + 0x2A, 0x10, 0xEB, 0x31, 0x08, 0x00,
> + 0x00, 0xA8, 0xA4, 0x1E, 0x98, 0xBB,
> + 0x1E, 0x98, 0x50, 0x14, 0x50, 0x04,
> + 0x46, 0x83, 0x48, 0x04, 0x02, 0x01,
> + 0x00, 0x50, 0x05, 0x50, 0x15, 0x10,
> + 0x87, 0x3F, 0x90, 0x2B, 0x18, 0x01,
> + 0x00, 0xC0, 0x31, 0x00, 0x00, 0xAE,
> + 0xDF, 0x41, 0x00, 0x08, 0x00, 0x1A,
> + 0x42, 0x11, 0x67, 0x01, 0xDF, 0x41,
> + 0x02, 0x08, 0x00, 0x10, 0x42, 0x11,
> + 0x62, 0x01, 0xB4, 0x43, 0x4A, 0x68,
> + 0x50, 0x14, 0x50, 0x04, 0x24, 0x10,
> + 0x48, 0x04, 0xF2, 0x31, 0x00, 0x01,
> + 0x00, 0x00, 0xAE, 0xF6, 0x31, 0x00,
> + 0x01, 0x00, 0x00, 0xAE, 0x62, 0xE4,
> + 0xE5, 0x61, 0x04, 0x48, 0x04, 0xE5,
> + 0x63, 0x05, 0x48, 0x04, 0x20, 0x20,
> + 0x00, 0x00, 0x00, 0x00
> };
>
> #endif
Shouldn't this be removed from the code, converted to a binary file and loaded
by the kernel firmware loader instead?
--
Ondrej Zary
next prev parent reply other threads:[~2013-11-04 12:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 12:15 [PATCH] Staging: ft1000: fixed a few styling issues Aldo Iljazi
2013-11-04 12:29 ` Dan Carpenter
2013-11-04 12:31 ` Aldo Iljazi
2013-11-04 12:32 ` Ondrej Zary [this message]
2013-11-04 12:58 ` Dan Carpenter
2013-11-12 0:24 ` Greg KH
2013-11-12 0:28 ` [PATCH] Staging: ft1000: boot.h: " Greg KH
-- strict thread matches above, loose matches on Subject: below --
2013-11-03 14:20 [PATCH] Staging: ft1000: " Aldo Iljazi
2013-11-03 23:10 ` Dan Carpenter
2013-11-04 8:17 ` Aldo Iljazi
2013-11-04 8:24 ` Dan Carpenter
2013-11-04 8:40 ` Aldo Iljazi
2013-11-04 8:45 ` Dan Carpenter
2013-11-04 8:46 ` Aldo Iljazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311041332.21209.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@aldo.io \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.