From: Antonio Quartulli <antonio@meshcoding.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: rename gw_deselect() to gw_reselect()
Date: Mon, 4 Nov 2013 15:11:58 +0100 [thread overview]
Message-ID: <20131104141158.GH970@neomailbox.net> (raw)
In-Reply-To: <1382875379-2921-2-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Sun, Oct 27, 2013 at 01:02:59PM +0100, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
>
> The function batadv_gw_deselect() is actually not deselecting
> anything. It is just informing the GW code to perform a
> re-election procedure when possible.
> The current gateway is not being touched at all and therefore
> the name of this function is rather misleading.
>
> Rename it to batadv_gw_reselect() to batadv_gw_reselect()
> to make its behaviour easier to grasp.
>
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
> ---
> gateway_client.c | 35 +++++++++++++++++++++++------------
> gateway_common.c | 2 +-
> sysfs.c | 10 +++++-----
The declaration of this function is in gw_client.h but I forgot to change it.
v2 will follow.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-04 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 12:02 [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: deselect current GW on client mode switch off Antonio Quartulli
2013-10-27 12:02 ` [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: rename gw_deselect() to gw_reselect() Antonio Quartulli
2013-11-04 14:11 ` Antonio Quartulli [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-04 19:59 [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: deselect current GW on client mode switch off Antonio Quartulli
2013-11-04 19:59 ` [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: rename gw_deselect() to gw_reselect() Antonio Quartulli
2013-11-05 7:59 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104141158.GH970@neomailbox.net \
--to=antonio@meshcoding.com \
--cc=antonio@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.