All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/4] ARM: deprecate mach/timex.h for !ARCH_MULTIPLATFORM
Date: Tue, 5 Nov 2013 12:34:42 +0100	[thread overview]
Message-ID: <201311051234.43321.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkdacQhwccK8nKf7m5aTA9ciHPuWth11v-OVPo0kS9WcUCQ@mail.gmail.com>

On Tuesday 05 November 2013, Linus Walleij wrote:
> On Tue, Nov 5, 2013 at 10:12 AM, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> 
> > +config NEED_MACH_TIMEX_H
> > +       bool
> > +       help
> > +         Select this when mach/timex.h is required to provide special
> > +         definitions for this platform. This should be avoided when possible.
> 
> OK this is no blocker, and do proceed with this as the kernel sure
> looks better after this than before it.
> 
> However as the next step I would prefer that we start to get rid of
> all the NEED_MACH_FOO_H used for just refactoring out headers.
> 
> Can we not completely do away with this header next, and provide
> the services it supplied locally in the mach-foo folder for these machines
> instead so we do not need to have all these Kconfig things and preserve
> the <mach/*> namespace for them?

Maybe we can collapse the CLOCK_TICK_RATE into a single Kconfig symbol
like


asm/timex.h:

#ifdef CONFIG_CLOCK_TICK_RATE
#define CLOCK_TICK_RATE CONFIG_CLOCK_TICK_RATE
#endif
/* EOF */

Kconfig:

config CLOCK_TICK_RATE
	int
	depends on !ARCH_MULTIPLATFORM && ARCH_USES_GETTIMEOFFSET
	depends on ARCH_GEMINI || ARCH_SA1100 || ARCH_EBSA110 || ARCH_EP93XX || ARCH_RPC || ARCH_AT91X40
	default 40000000 if ARCH_AT91X40
	default 38000000 if ARCH_GEMINI
	default 3686400 if ARCH_SA1100
	default 47894000 if ARCH_EBSA110
	default 983040 if ARCH_EP93xx
	default 2000000 if ARCH_RPC
	# don't even think about adding more to this list, better get rid of the
	# existing ones by converting them to proper clocksources

> The real trick is to make CLOCK_TICK_RATE and LATCH runtime
> variables instead of a compile-time variables, right? Can't we do
> this?

We've almost killed off CLOCK_TICK_RATE for anything that matters, I'd prefer not
doing anything to it other than reducing its uses to the places that we know need
it.

	Arnd

  parent reply	other threads:[~2013-11-05 11:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04 10:58 [PATCH v4 0/4] Energy Micro efm32 support Uwe Kleine-König
2013-11-04 11:00 ` [PATCH v4 1/4] ARM: deprecate mach/timex.h for !ARCH_MULTIPLATFORM Uwe Kleine-König
2013-11-04 13:53   ` Arnd Bergmann
2013-11-05  8:33     ` Uwe Kleine-König
2013-11-05  9:03       ` [PATCH] ARM: u300: fix timekeeping when periodic mode is used Uwe Kleine-König
2013-11-05  9:44         ` Linus Walleij
2013-11-25 21:13           ` Uwe Kleine-König
2013-11-26 12:32             ` Linus Walleij
2013-11-05  9:12       ` [PATCH v5 1/4] ARM: deprecate mach/timex.h for !ARCH_MULTIPLATFORM Uwe Kleine-König
2013-11-05  9:42         ` Linus Walleij
2013-11-05 10:01           ` Uwe Kleine-König
2013-11-05 11:34           ` Arnd Bergmann [this message]
2013-11-05 11:37             ` Linus Walleij
2013-11-05 11:45             ` Russell King - ARM Linux
2013-11-05 12:26               ` Arnd Bergmann
2013-11-05 13:27                 ` Uwe Kleine-König
2013-11-05 14:58                   ` Arnd Bergmann
2013-11-05 11:52             ` Uwe Kleine-König
2013-11-04 11:00 ` [PATCH v4 2/4] ARM: make mach-xyz/Makefile.boot optional " Uwe Kleine-König
2013-11-11 19:35   ` Olof Johansson
2015-01-30  9:32     ` Uwe Kleine-König
2013-11-04 11:00 ` [PATCH v4 3/4] ARM: v7-M: drop using mach/entry-macro.S Uwe Kleine-König
2013-11-11 19:35   ` Olof Johansson
2013-11-04 11:00 ` [PATCH v4 4/4] ARM: new platform for Energy Micro's EFM32 Cortex-M3 SoCs Uwe Kleine-König
2013-11-04 13:56   ` Arnd Bergmann
2013-11-05  9:48     ` Uwe Kleine-König
2013-11-05 11:10       ` Arnd Bergmann
2013-11-19 10:20 ` [PATCH v4 0/4] Energy Micro efm32 support Uwe Kleine-König
2013-11-19 13:11   ` Arnd Bergmann
2013-11-19 19:08     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201311051234.43321.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.