From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Vdmrv-00074W-Ml
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 15:05:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Vdmrq-0008WT-NK
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 15:04:55 -0500
Received: from nodalink.pck.nerim.net ([62.212.105.220]:40797
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Vdmrq-0008W6-Dq
	for qemu-devel@nongnu.org; Tue, 05 Nov 2013 15:04:50 -0500
Date: Tue, 5 Nov 2013 21:04:43 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20131105200442.GA2991@irqsave.net>
References: <1383678213-2497-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1383678213-2497-1-git-send-email-mreitz@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Le Tuesday 05 Nov 2013 =E0 20:03:33 (+0100), Max Reitz a =E9crit :
> error_setg_errno() may overwrite errno; therefore, its value should be
> read before calling that function and not afterwards.
>=20
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/block.c b/block.c
> index 58efb5b..0e96a22 100644
> --- a/block.c
> +++ b/block.c
> @@ -1084,8 +1084,8 @@ int bdrv_open(BlockDriverState *bs, const char *f=
ilename, QDict *options,
>              snprintf(backing_filename, sizeof(backing_filename),
>                       "%s", filename);
>          } else if (!realpath(filename, backing_filename)) {
> -            error_setg_errno(errp, errno, "Could not resolve path '%s'=
", filename);
>              ret =3D -errno;
> +            error_setg_errno(errp, errno, "Could not resolve path '%s'=
", filename);
>              goto fail;
>          }
> =20
> --=20
> 1.8.4.2
>=20

Reviewed-by: Benoit Canet <benoit@irqsave.net>
>=20