From: Anders Roxell <anders.roxell@linaro.org>
To: openembedded-devel@lists.openembedded.org
Cc: linaro-networking@linaro.org, "patches@linaro.org" <patches@linaro.org>
Subject: Re: [PATCH] libhugetlbfs: add support for armv7a
Date: Wed, 6 Nov 2013 10:05:12 +0100 [thread overview]
Message-ID: <20131106090512.GA1839@nexon.se> (raw)
In-Reply-To: <CAMKF1sp9WfTh6qdmNc9noCq24cf=R52OOdvtqEjZU7h10Vun-A@mail.gmail.com>
On 2013-10-28 18:42, Khem Raj wrote:
> On Fri, Oct 18, 2013 at 7:09 AM, Anders Roxell <anders.roxell@linaro.org> wrote:
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > index 24480c3..4f1bfa4 100644
> > --- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > +++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> > @@ -20,10 +20,16 @@ SRC_URI = "git://git.code.sf.net/p/libhugetlbfs/code \
> >
> > S = "${WORKDIR}/git"
> >
> > -COMPATIBLE_HOST = "(x86_64|powerpc|powerpc64|aarch64).*-linux*"
> > +COMPATIBLE_HOST = "(x86_64|powerpc|powerpc64|arm|aarch64).*-linux*"
> >
> > +python __anonymous() {
> > + if base_contains('TARGET_ARCH', 'arm', True, False, d):
> > + d.setVar('ARCH', 'armv7l')
> > + else:
> > + d.setVar('ARCH', d.getVar('TARGET_ARCH'))
> > +}
I'm sorry for the late response.
>
> instead of this fugly anon python you could do
>
> ARCH_arm = "armv7l"
> ARCH ?= "${TARGET_ARCH}"
Much better, thanks!
>
> and btw. we support ARM v4,v5,v6 architectures as well. It seems your
> patch only cares about armv7,
> and if this recipe only works for armv7+ then dont open the floodgates
> for all kind of arm architectures.
Agree.
Will send out patch v2.
Cheers,
Anders
>
> >
> > -EXTRA_OEMAKE = "'ARCH=${TARGET_ARCH}' 'OPT=${CFLAGS}' 'CC=${CC}' BUILDTYPE=NATIVEONLY ${LIBARGS}"
> > +EXTRA_OEMAKE = "'ARCH=${ARCH}' 'OPT=${CFLAGS}' 'CC=${CC}' BUILDTYPE=NATIVEONLY ${LIBARGS}"
> > CFLAGS += "-fexpensive-optimizations -frename-registers -fomit-frame-pointer -g0"
> >
> > TARGET_CC_ARCH += "${LDFLAGS}"
> > --
> > 1.8.1.2
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
prev parent reply other threads:[~2013-11-06 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 14:09 [PATCH] libhugetlbfs: add support for armv7a Anders Roxell
2013-10-28 8:26 ` Martin Jansa
2013-11-07 16:03 ` Anders Roxell
2013-11-08 11:29 ` Martin Jansa
2013-10-29 1:42 ` Khem Raj
2013-11-06 9:05 ` Anders Roxell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106090512.GA1839@nexon.se \
--to=anders.roxell@linaro.org \
--cc=linaro-networking@linaro.org \
--cc=openembedded-devel@lists.openembedded.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.