From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 17/24] dm cache: use a boolean when setting cache->quiescing Date: Wed, 6 Nov 2013 10:25:52 -0500 Message-ID: <20131106152551.GA409@redhat.com> References: <1382639437-27007-1-git-send-email-snitzer@redhat.com> <1382639437-27007-18-git-send-email-snitzer@redhat.com> <20131106150205.GB30597@agk-dp.fab.redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131106150205.GB30597@agk-dp.fab.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: dm-devel@redhat.com, Morgan Mears , Heinz Mauelshagen , Joe Thornber List-Id: dm-devel.ids On Wed, Nov 06 2013 at 10:02am -0500, Alasdair G Kergon wrote: > On Thu, Oct 24, 2013 at 02:30:30PM -0400, Mike Snitzer wrote: > > From: Heinz Mauelshagen > > > > Signed-off-by: Heinz Mauelshagen > > Signed-off-by: Mike Snitzer > > Please could we drop this one? > > It looks pointless to me, with this one following: > dm cache: improve effciency of quiescing flag management It was just a change for consistency that happened during the natural flow of development. Really didn't see a problem with preserving the evolution of the code... But sure, I can drop it.