From: Dave Jones <davej@redhat.com>
To: linux-ext4@vger.kernel.org
Subject: [PATCH] Add missing brelse to xattr code.
Date: Wed, 6 Nov 2013 10:45:46 -0500 [thread overview]
Message-ID: <20131106154546.GA27255@redhat.com> (raw)
This code was recently patched to not leak memory on the retry path,
but it seems we are also forgetting to brelse the bufferhead.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 03e9bebba198..1423c4816a47 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1352,6 +1352,7 @@ retry:
new_extra_isize = s_min_extra_isize;
kfree(is); is = NULL;
kfree(bs); bs = NULL;
+ brelse(bh);
goto retry;
}
error = -1;
next reply other threads:[~2013-11-06 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 15:45 Dave Jones [this message]
2013-11-12 1:08 ` Add missing brelse to xattr code Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106154546.GA27255@redhat.com \
--to=davej@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.