From: Borislav Petkov <bp@alien8.de>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Doug Thompson <dougthompson@xmission.com>,
Robert Richter <rric@kernel.org>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK
Date: Wed, 6 Nov 2013 17:54:38 +0100 [thread overview]
Message-ID: <20131106165437.GA21870@x1.alien8.de> (raw)
In-Reply-To: <527A6B08.5020302@gmail.com>
On Wed, Nov 06, 2013 at 10:15:04AM -0600, Rob Herring wrote:
> Other maintainers disagree because it reduces build coverage.
What possible build coverage are we talking about when building highbank
on x86, for example? And what does a build failure in that configuration
tell you if it builds and boots fine on your hardware?
> Having done some cross arch clean-up, I have to agree with that
> position. Iterating builds over different arches is bad enough, but
> iterating over all configs for each arch is a pain.
So make highbank depend only on the arches for which it is supposed to
work but not for *all* arches. Look at how the other edac drivers do it,
x86 ones depend on X86, tile on tile, etc, etc. Why should highbank be
special?
> It would be nice to have a uniform policy here.
Simple: drivers should be selectable/buildable only on the arches
they're supposed to run on.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2013-11-06 16:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 3:25 [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK Rob Herring
2013-11-06 14:20 ` Borislav Petkov
2013-11-06 16:15 ` Rob Herring
2013-11-06 16:54 ` Borislav Petkov [this message]
2013-11-06 17:17 ` Rob Herring
2013-11-07 12:27 ` Borislav Petkov
2013-11-07 13:23 ` Rob Herring
2013-11-07 13:33 ` Borislav Petkov
2013-11-08 13:59 ` Robert Richter
2013-11-08 14:47 ` Borislav Petkov
2013-11-11 10:29 ` Robert Richter
2013-11-11 10:47 ` Borislav Petkov
2013-11-11 11:09 ` Robert Richter
2013-11-11 15:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106165437.GA21870@x1.alien8.de \
--to=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.