From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gcc: use generic infrastructure for patches
Date: Thu, 7 Nov 2013 00:13:43 +0100 [thread overview]
Message-ID: <20131107001343.7f90de1c@skate> (raw)
In-Reply-To: <1383778795-15262-1-git-send-email-arnout@mind.be>
Dear Arnout Vandecappelle (Essensium/Mind),
On Wed, 6 Nov 2013 23:59:55 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> package/gcc/gcc-final/4.2.2-avr32-2.1.5 | 1 +
> package/gcc/gcc-final/4.3.6 | 1 +
> package/gcc/gcc-final/4.4.7 | 1 +
> package/gcc/gcc-final/4.5.4 | 1 +
> package/gcc/gcc-final/4.6.4 | 1 +
> package/gcc/gcc-final/4.7.3 | 1 +
> package/gcc/gcc-final/4.8-arc | 1 +
> package/gcc/gcc-final/4.8.2 | 1 +
The only problem that I see with this symbolic link based solution is
that we will have to remember to add/update the three symbolic each
time we do a gcc version bump. If we forget to do so, then the build
will go on silently, but without having applied the patches.
I don't say this problem is a show-stopper, but it's a drawback of this
symbolic link solution, IMO.
> define HOST_GCC_APPLY_POWERPC_PATCH
> - support/scripts/apply-patches.sh $(@D) package/gcc/$(GCC_VERSION) powerpc-link-with-math-lib.patch.conditional
> + if [ -e package/gcc/$(GCC_VERSION)/powerpc-link-with-math-lib.patch.conditional ]; then \
> + support/scripts/apply-patches.sh $(@D) package/gcc/$(GCC_VERSION) powerpc-link-with-math-lib.patch.conditional; \
> + fi
Why was adding the condition necessary?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-06 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 13:00 [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package Andi Shyti
2013-11-05 18:51 ` Arnout Vandecappelle
2013-11-05 20:17 ` Andi Shyti
2013-11-06 21:32 ` Arnout Vandecappelle
2013-11-06 22:16 ` Thomas Petazzoni
2013-11-06 22:59 ` [Buildroot] [PATCH] gcc: use generic infrastructure for patches Arnout Vandecappelle
2013-11-06 23:13 ` Thomas Petazzoni [this message]
2013-11-06 23:17 ` Peter Korsgaard
2013-11-06 23:20 ` Arnout Vandecappelle
2013-11-06 23:23 ` Arnout Vandecappelle
2013-11-07 1:19 ` Andi Shyti
2013-11-06 23:40 ` [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107001343.7f90de1c@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.