From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 13/31] ASoC: wm_adsp: Fix BUG_ON() and WARN_ON() usages
Date: Thu, 7 Nov 2013 10:19:39 +0000 [thread overview]
Message-ID: <20131107101939.GJ30879@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hk3gle0tt.wl%tiwai@suse.de>
On Wed, Nov 06, 2013 at 09:23:42PM +0100, Takashi Iwai wrote:
> At Wed, 6 Nov 2013 18:44:22 +0000,
> Charles Keepax wrote:
> > These do make me a little nervous previously we would panic here,
> > so everything would stop but now we may write random registers on
> > the CODEC which could cause some odd behaviour. I think it would
> > be better to update wm_adsp_region_to_reg to allow a failed
> > return code and then error out of wm_adsp_load rather than just
> > relying on the WARN_ON inside.
>
> Yeah, handling the error properly would be definitely better.
> Care to enhance the patch?
Yeah fair enough, lets merge the patch as is and I will send out a
seperate patch once I get a few spare minutes to improve the
error handling in this bit of code.
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2013-11-07 10:19 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 17:39 [PATCH 00/31] Kill BUG*() volume 2: ASoC Takashi Iwai
2013-11-05 17:39 ` [PATCH 01/31] ASoC: blackfin: Use WARN_ON() instead of BUG_ON() Takashi Iwai
2013-11-06 10:00 ` Mark Brown
2013-11-05 17:39 ` [PATCH 02/31] ASoC: max98088: " Takashi Iwai
2013-11-06 10:18 ` Mark Brown
2013-11-05 17:39 ` [PATCH 03/31] ASoC: max98095: " Takashi Iwai
2013-11-06 10:17 ` Mark Brown
2013-11-05 17:39 ` [PATCH 04/31] ASoC: tpa6130a2: " Takashi Iwai
2013-11-06 10:18 ` Mark Brown
2013-11-05 17:39 ` [PATCH 05/31] ASoC: wm0010: " Takashi Iwai
2013-11-06 10:31 ` Mark Brown
2013-11-05 17:39 ` [PATCH 06/31] ASoC: wm2000: " Takashi Iwai
2013-11-06 10:31 ` Mark Brown
2013-11-05 17:39 ` [PATCH 07/31] ASoC: wm8580: Use WARN() " Takashi Iwai
2013-11-06 10:31 ` Mark Brown
2013-11-05 17:39 ` [PATCH 08/31] ASoC: wm5100: Use WARN_ON() " Takashi Iwai
2013-11-06 10:32 ` Mark Brown
2013-11-05 17:39 ` [PATCH 09/31] ASoC: wm8776: " Takashi Iwai
2013-11-06 10:32 ` Mark Brown
2013-11-05 17:39 ` [PATCH 10/31] ASoC: wm8900: " Takashi Iwai
2013-11-06 10:32 ` Mark Brown
2013-11-05 17:39 ` [PATCH 11/31] ASoC: wm8904: " Takashi Iwai
2013-11-06 10:32 ` Mark Brown
2013-11-05 17:39 ` [PATCH 12/31] ASoC: wm9713: " Takashi Iwai
2013-11-06 10:33 ` Mark Brown
2013-11-05 17:40 ` [PATCH 13/31] ASoC: wm_adsp: Fix BUG_ON() and WARN_ON() usages Takashi Iwai
2013-11-06 18:44 ` Charles Keepax
2013-11-06 20:23 ` Takashi Iwai
2013-11-07 10:19 ` Charles Keepax [this message]
2013-11-07 10:47 ` Mark Brown
2013-11-07 11:07 ` Takashi Iwai
2013-11-07 11:51 ` Mark Brown
2013-11-07 12:03 ` Takashi Iwai
2013-11-07 11:38 ` Mark Brown
2013-11-05 17:40 ` [PATCH 14/31] ASoC: mid-x86: Use WARN_ON() instead of BUG_ON() Takashi Iwai
2013-11-06 10:33 ` Mark Brown
2013-11-05 17:40 ` [PATCH 15/31] ASoC: omap: " Takashi Iwai
2013-11-05 18:54 ` Jarkko Nikula
2013-11-06 10:34 ` Mark Brown
2013-11-05 17:40 ` [PATCH 16/31] ASoC: pxa: " Takashi Iwai
2013-11-06 10:34 ` Mark Brown
2013-11-05 17:40 ` [PATCH 17/31] ASoC: s6000: " Takashi Iwai
2013-11-06 10:34 ` Mark Brown
2013-11-05 17:40 ` [PATCH 18/31] ASoC: rcar: " Takashi Iwai
2013-11-06 0:22 ` Kuninori Morimoto
2013-11-06 10:34 ` Mark Brown
2013-11-05 17:40 ` [PATCH 19/31] ASoC: sh: " Takashi Iwai
2013-11-06 0:21 ` Kuninori Morimoto
2013-11-06 10:35 ` Mark Brown
2013-11-05 17:40 ` [PATCH 20/31] ASoC: txx9: " Takashi Iwai
2013-11-06 10:35 ` Mark Brown
2013-11-05 17:40 ` [PATCH 21/31] ASoC: dapm: " Takashi Iwai
2013-11-06 10:24 ` Mark Brown
2013-11-06 11:05 ` Takashi Iwai
2013-11-06 11:15 ` Mark Brown
2013-11-06 11:33 ` Takashi Iwai
2013-11-06 11:48 ` Mark Brown
2013-11-06 12:03 ` Takashi Iwai
2013-11-06 16:03 ` Mark Brown
2013-11-06 17:21 ` Takashi Iwai
2013-11-06 23:48 ` Mark Brown
2013-11-07 7:31 ` Takashi Iwai
2013-11-07 11:31 ` Mark Brown
2013-11-07 17:38 ` Takashi Iwai
2013-11-07 20:01 ` Mark Brown
2013-11-07 20:19 ` Takashi Iwai
2013-11-05 17:40 ` [PATCH 22/31] ASoC: wm5100: Replace BUG() with snd_BUG() Takashi Iwai
2013-11-05 17:40 ` [PATCH 23/31] ASoC: wm8350: " Takashi Iwai
2013-11-05 17:40 ` [PATCH 24/31] ASoC: wm8900: " Takashi Iwai
2013-11-05 17:40 ` [PATCH 25/31] ASoC: wm8904: " Takashi Iwai
2013-11-05 17:40 ` [PATCH 26/31] ASoC: wm8958: " Takashi Iwai
2013-11-05 17:40 ` [PATCH 27/31] ASoC: wm8962: " Takashi Iwai
2013-11-05 17:40 ` [PATCH 28/31] ASoC: wm8996: " Takashi Iwai
2013-11-05 17:40 ` [PATCH 29/31] ASoC: wm_hubs: " Takashi Iwai
2013-11-05 17:40 ` [PATCH 30/31] ASoC: " Takashi Iwai
2013-11-06 9:39 ` Mark Brown
2013-11-06 10:04 ` Takashi Iwai
2013-11-05 17:40 ` [PATCH 31/31] ASoC: max98095: Add missing negative channel checks Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107101939.GJ30879@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.