From: Bob Copeland <me@bobcopeland.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath5k tx completion
Date: Thu, 7 Nov 2013 09:20:04 -0500 [thread overview]
Message-ID: <20131107142004.GA15085@localhost> (raw)
In-Reply-To: <CAJ-Vmo=20LNEiWPHOCBVU9-+aT_qkpoY+E_BwtiM6=8QFs09xw@mail.gmail.com>
On Wed, Nov 06, 2013 at 09:17:46AM -0800, Adrian Chadd wrote:
> The TL;DR version - you need to keep the the final descriptor around
> for each hardware queue. The legacy madwifi/freebsd way of doing it
> was to keep the last descriptor that was handled. This wasn't enough.
> It needs to be per TX queue. You also must never program TxDP after
> you've programmed it once - you can only program it again after you've
> completely torn down TX DMA for the particular queue.
This is a goldmine -- thank you for taking the time to write it up!
I believe we can clean up ath5k's transmit loop a lot now...
> * read-and-clear bugs
> * PHY register read problems, and why ANI may occasionally look whacked
One thing at a time for me... but do we even want to know? :)
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2013-11-07 14:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131106134108.GB5022@localhost>
2013-11-06 17:17 ` [ath9k-devel] ath5k tx completion Adrian Chadd
2013-11-07 14:20 ` Bob Copeland [this message]
2013-11-07 17:43 ` Adrian Chadd
2013-11-07 18:17 ` Peter Stuge
2013-11-09 13:40 ` [ath9k-devel] [ath5k-devel] " Nick Kossifidis
2013-11-09 15:54 ` Adrian Chadd
2013-11-09 16:15 ` Bob Copeland
2013-11-09 17:55 ` Nick Kossifidis
2013-11-09 19:14 ` Bob Copeland
2014-02-24 10:19 ` Nick Kossifidis
2014-02-24 18:39 ` Sarah Sharp
2014-02-25 5:30 ` Adrian Chadd
2014-02-25 9:23 ` Nick Kossifidis
2014-02-25 11:23 ` Adrian Chadd
2014-02-25 12:24 ` Bob Copeland
2014-02-26 9:50 ` Nick Kossifidis
2014-02-26 17:37 ` Adrian Chadd
2014-02-27 0:19 ` Sarah Sharp
2013-11-09 17:51 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107142004.GA15085@localhost \
--to=me@bobcopeland.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.