From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] serial: omap: Add support for optional wake-up Date: Thu, 7 Nov 2013 12:01:25 -0800 Message-ID: <20131107200125.GM15154@atomide.com> References: <20131022134947.GK15154@atomide.com> <87siv8rqmj.fsf@linaro.org> <20131107194553.GL15154@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:47085 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752249Ab3KGUB3 (ORCPT ); Thu, 7 Nov 2013 15:01:29 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Olof Johansson Cc: Kevin Hilman , Greg Kroah-Hartman , linux-omap , "linux-arm-kernel@lists.infradead.org" , Linus Walleij , Roger Quadros * Olof Johansson [131107 11:48]: > On Thu, Nov 7, 2013 at 11:45 AM, Tony Lindgren wrote: > > * Kevin Hilman [131107 10:53]: > >> > >> A bunch of DT boot failures on OMAP3 platforms with latest mainline were > >> bisected down to this patch. Boot results here: > >> http://lists.linaro.org/pipermail/kernel-build-reports/2013-November/000954.html > >> > >> This doesn't seem to properly handle the OMAP3 case where we have DT > >> nodes, but no reg or interrupts properties since they're still using > >> hwmod. > >> > >> The problems seems to be because these OMAP3 platforms don't list any > >> interrupts in their DTS files for the UARTs, but a quick hack at adding > >> interrupts to omap3.dtsi didn't help either so something else is going > >> on. > >> > >> This patch should probably be reverted until it gets broader testing. > > > > Hmm I'm not seeing this with my tree, and sounds like it should be > > already fixed by commit d7c8f2596 (ARM: dts: Add missing reg, > > interrupt and dma entries for omap3). > > > > Can you check that you have that commit in your tree? > > Ah, that explains why we haven't seen it in -next. Yeah looks like there's a dependency that I missed. I probably tested the serial patch separately with omap4 only. > We should probably queue up our branches for Linus to merge ASAP, > that'll take care of it. Yeah. This issue should be of limited damage as most omap3 boards are not DT only yet, that won't happen until for v3.14. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 7 Nov 2013 12:01:25 -0800 Subject: [PATCH v2] serial: omap: Add support for optional wake-up In-Reply-To: References: <20131022134947.GK15154@atomide.com> <87siv8rqmj.fsf@linaro.org> <20131107194553.GL15154@atomide.com> Message-ID: <20131107200125.GM15154@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Olof Johansson [131107 11:48]: > On Thu, Nov 7, 2013 at 11:45 AM, Tony Lindgren wrote: > > * Kevin Hilman [131107 10:53]: > >> > >> A bunch of DT boot failures on OMAP3 platforms with latest mainline were > >> bisected down to this patch. Boot results here: > >> http://lists.linaro.org/pipermail/kernel-build-reports/2013-November/000954.html > >> > >> This doesn't seem to properly handle the OMAP3 case where we have DT > >> nodes, but no reg or interrupts properties since they're still using > >> hwmod. > >> > >> The problems seems to be because these OMAP3 platforms don't list any > >> interrupts in their DTS files for the UARTs, but a quick hack at adding > >> interrupts to omap3.dtsi didn't help either so something else is going > >> on. > >> > >> This patch should probably be reverted until it gets broader testing. > > > > Hmm I'm not seeing this with my tree, and sounds like it should be > > already fixed by commit d7c8f2596 (ARM: dts: Add missing reg, > > interrupt and dma entries for omap3). > > > > Can you check that you have that commit in your tree? > > Ah, that explains why we haven't seen it in -next. Yeah looks like there's a dependency that I missed. I probably tested the serial patch separately with omap4 only. > We should probably queue up our branches for Linus to merge ASAP, > that'll take care of it. Yeah. This issue should be of limited damage as most omap3 boards are not DT only yet, that won't happen until for v3.14. Regards, Tony