From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vejw3-0000tA-4B for qemu-devel@nongnu.org; Fri, 08 Nov 2013 06:09:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vejvq-0000fY-QX for qemu-devel@nongnu.org; Fri, 08 Nov 2013 06:09:07 -0500 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:44931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vejvq-0000eI-Cz for qemu-devel@nongnu.org; Fri, 08 Nov 2013 06:08:54 -0500 Date: Fri, 8 Nov 2013 13:20:44 +1000 From: David Gibson Message-ID: <20131108032044.GC3949@voom.vod.net.au> References: <43554ff123173340b2c66b2dd28da9e231258d71.1383694977.git.crobinso@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GZVR6ND4mMseVXL/" Content-Disposition: inline In-Reply-To: <43554ff123173340b2c66b2dd28da9e231258d71.1383694977.git.crobinso@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] Fix pc migration from qemu <= 1.5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: mst@redhat.com, qemu-stable@nongnu.org, alex.williamson@redhat.com, qemu-devel@nongnu.org, bsd@redhat.com, aliguori@amazon.com, pbonzini@redhat.com --GZVR6ND4mMseVXL/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 05, 2013 at 06:46:27PM -0500, Cole Robinson wrote: > The following commit introduced a migration incompatibility: >=20 > commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe > Author: David Gibson > Date: Thu Jun 6 18:48:49 2013 +1000 >=20 > pci: Replace pci_find_domain() with more general pci_root_bus_path() >=20 > The issue is that i440fx savevm idstr went from 0000:00:00.0/I440FX to > 0000:00.0/I440FX. Unfortunately we are stuck with the breakage for > 1.6 machine types. >=20 > Add a compat property to maintain the busted idstr for the 1.6 machine > types, but revert to the old style format for 1.7+, and <=3D 1.5. >=20 > Tested with migration from qemu 1.5, qemu 1.6, and qemu.git. Bother. I did think about migration compatibility for x86, but obviously not quite hard enough :(. Sorry, folks. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GZVR6ND4mMseVXL/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJSfFiMAAoJEGw4ysog2bOSQm4P/3DNH75CG51K1/92EjB+Nzpu Jchz6kBbfYcaGjCBS0Hy+LLHSEiYJsJYdM3+DAa89ZJY0yOMkMN2DsmvUDMOpDG0 RP6YUaicgXEeFVaoAUNV6/jZJvpyILfT+Snao+G+9nAGFEDmNYnnGnLkEfe2VLE9 T4FL2TEs+gAttRhTIK/W6xGQUSSJGPbm8lox8B7j2zwp2vgF9tfPE0i/JA35Qubx 2/B1F1n3gtybbmWeDBmppGU4j8+/WwlDvN96luialbti3UTuAYdcMS0K6obg/tsC du7gg44IlLoPWpi1PWdPmtS5gmpI9atqkRZ08dKK6IhU7oAEPiFRj+ow4HIudd0t Oo5OZEsSsPP+Taj6+5wSOxiMJcEuG+sOumZ88MIQYv/qRgpuTaDHwdomwGWIXw0T Kw4Mh9mXpBzKdiSZrqYJzaC44PgAsl72QztqWEr9ARCaKuaAvLN2p/KDqwu8T8gL EVmFG4ZN3THHzrS3B+544PQ0K5j7d9RhYaqD1JQNrBnUJ+Tf5Yot3k+NXwr1xqWp +cRKmyqSLg0Z53QWvahfG1azJkXDUt2tvES9+52wKpgbnrYWiSz+G+91dE/pBD0f +bAZQ9jh7Y4SaJ+ztDmPvv8+KGxrN0vRt/qNyXaK+lDSsFLrcBKUf4n4QixRvwfA nO/JEJVqbaGecT63WLlf =fvOh -----END PGP SIGNATURE----- --GZVR6ND4mMseVXL/--