All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Phillip Lougher <phillip@squashfs.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] Squashfs: restructure squashfs_readpage()
Date: Fri, 8 Nov 2013 15:02:19 +0900	[thread overview]
Message-ID: <20131108060218.GC4038@bbox> (raw)
In-Reply-To: <1383855865-4683-6-git-send-email-phillip@squashfs.org.uk>

On Thu, Nov 07, 2013 at 08:24:24PM +0000, Phillip Lougher wrote:
> Restructure squashfs_readpage() splitting it into separate
> functions for datablocks, fragments and sparse blocks.
> 
> Move the memcpying (from squashfs cache entry) implementation of
> squashfs_readpage_block into file_cache.c
> 
> This allows different implementations to be supported.
> 
> Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk>
> ---
>  fs/squashfs/Makefile     |    2 +-
>  fs/squashfs/file.c       |  142 +++++++++++++++++++++++-----------------------
>  fs/squashfs/file_cache.c |   38 +++++++++++++
>  fs/squashfs/squashfs.h   |    7 +++
>  4 files changed, 118 insertions(+), 71 deletions(-)
>  create mode 100644 fs/squashfs/file_cache.c
> 
> diff --git a/fs/squashfs/Makefile b/fs/squashfs/Makefile
> index 5833b96..908c0d9 100644
> --- a/fs/squashfs/Makefile
> +++ b/fs/squashfs/Makefile
> @@ -4,7 +4,7 @@
>  
>  obj-$(CONFIG_SQUASHFS) += squashfs.o
>  squashfs-y += block.o cache.o dir.o export.o file.o fragment.o id.o inode.o
> -squashfs-y += namei.o super.o symlink.o decompressor.o
> +squashfs-y += namei.o super.o symlink.o decompressor.o file_cache.c

                                                          file_cache.o

-- 
Kind regards,
Minchan Kim

  parent reply	other threads:[~2013-11-08  6:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 20:24 [PATCH 0/6] Squashfs performance improvements Phillip Lougher
2013-11-07 20:24 ` [PATCH 1/6] Squashfs: Refactor decompressor interface and code (V2) Phillip Lougher
2013-11-07 20:24 ` [PATCH 2/6] Squashfs: enhance parallel I/O Phillip Lougher
2013-11-07 20:24 ` [PATCH 3/6] Squashfs: add multi-threaded decompression using percpu variables Phillip Lougher
2013-11-08  2:42   ` Minchan Kim
2013-11-14 17:04     ` Phillip Lougher
2013-11-18  8:08       ` J. R. Okajima
2013-11-19  2:12       ` Minchan Kim
2013-11-07 20:24 ` [PATCH 4/6] Squashfs: Generalise paging handling in the decompressors (V2) Phillip Lougher
2013-11-08  5:29   ` Minchan Kim
2013-11-07 20:24 ` [PATCH 5/6] Squashfs: restructure squashfs_readpage() Phillip Lougher
2013-11-08  5:55   ` Minchan Kim
2013-11-08  6:02   ` Minchan Kim [this message]
2013-11-07 20:24 ` [PATCH 6/6] Squashfs: Directly decompress into the page cache for file data (V2) Phillip Lougher
2013-11-08  8:23   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131108060218.GC4038@bbox \
    --to=minchan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@squashfs.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.