From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/04] ARM: shmobile: Remove legacy KZM9D board code
Date: Fri, 08 Nov 2013 23:34:10 +0000 [thread overview]
Message-ID: <20131108233409.GC4017@verge.net.au> (raw)
In-Reply-To: <CANqRtoQdgUqDC6LCkC91G6TD=cgK2ya-M4miPGdhdEPVmc_efQ@mail.gmail.com>
On Fri, Nov 08, 2013 at 07:03:22PM +0900, Magnus Damm wrote:
> On Fri, Nov 8, 2013 at 5:49 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Nov 07, 2013 at 08:21:29AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Remove the C and platform device version of KZM9D.
> >>
> >> The DT version of KZM9D board support can now instead
> >> directly be used with SoC specific code in setup-emev2.c.
> >
> > Am I right in thinking that with this change in place we need the following
> > change to the defconfig in order for it to compile.
> >
> > diff --git a/arch/arm/configs/kzm9d_defconfig b/arch/arm/configs/kzm9d_defconfig
> > index 6c37f4a..002488a 100644
> > --- a/arch/arm/configs/kzm9d_defconfig
> > +++ b/arch/arm/configs/kzm9d_defconfig
> > @@ -13,7 +13,7 @@ CONFIG_SLAB=y
> > # CONFIG_BLK_DEV_BSG is not set
> > # CONFIG_IOSCHED_DEADLINE is not set
> > # CONFIG_IOSCHED_CFQ is not set
> > -CONFIG_ARCH_SHMOBILE=y
> > +CONFIG_ARCH_SHMOBILE_MULTI=y
> > CONFIG_ARCH_EMEV2=y
> > CONFIG_MACH_KZM9D=y
> > CONFIG_MEMORY_START=0x40000000
> >
> >
> > I am holding off on pushing the patches I queued up today until
> > this can be resolved one way or another.
>
> Oh, right, I guess it doesn't know the link address now when the C
> bits are gone. Sorry about that, I totally forgot about the defconfig.
>
> At this point I think we should fix up the defconfig to build for
> kzm9d with single platform. So instead of enabling MULTI in the
> kzmd_defconfig, how about this?
>
> CONFIG_AUTO_ZRELADDR=y
>
> Also, it seems that the "select USE_OF" went away with the board code
> Kconfig bits. I will send a patch for that right away.
Thanks. USE_OF + CONFIG_AUTO_ZRELADDR appears to work :)
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/04] ARM: shmobile: Remove legacy KZM9D board code
Date: Sat, 9 Nov 2013 08:34:10 +0900 [thread overview]
Message-ID: <20131108233409.GC4017@verge.net.au> (raw)
In-Reply-To: <CANqRtoQdgUqDC6LCkC91G6TD=cgK2ya-M4miPGdhdEPVmc_efQ@mail.gmail.com>
On Fri, Nov 08, 2013 at 07:03:22PM +0900, Magnus Damm wrote:
> On Fri, Nov 8, 2013 at 5:49 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Nov 07, 2013 at 08:21:29AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Remove the C and platform device version of KZM9D.
> >>
> >> The DT version of KZM9D board support can now instead
> >> directly be used with SoC specific code in setup-emev2.c.
> >
> > Am I right in thinking that with this change in place we need the following
> > change to the defconfig in order for it to compile.
> >
> > diff --git a/arch/arm/configs/kzm9d_defconfig b/arch/arm/configs/kzm9d_defconfig
> > index 6c37f4a..002488a 100644
> > --- a/arch/arm/configs/kzm9d_defconfig
> > +++ b/arch/arm/configs/kzm9d_defconfig
> > @@ -13,7 +13,7 @@ CONFIG_SLAB=y
> > # CONFIG_BLK_DEV_BSG is not set
> > # CONFIG_IOSCHED_DEADLINE is not set
> > # CONFIG_IOSCHED_CFQ is not set
> > -CONFIG_ARCH_SHMOBILE=y
> > +CONFIG_ARCH_SHMOBILE_MULTI=y
> > CONFIG_ARCH_EMEV2=y
> > CONFIG_MACH_KZM9D=y
> > CONFIG_MEMORY_START=0x40000000
> >
> >
> > I am holding off on pushing the patches I queued up today until
> > this can be resolved one way or another.
>
> Oh, right, I guess it doesn't know the link address now when the C
> bits are gone. Sorry about that, I totally forgot about the defconfig.
>
> At this point I think we should fix up the defconfig to build for
> kzm9d with single platform. So instead of enabling MULTI in the
> kzmd_defconfig, how about this?
>
> CONFIG_AUTO_ZRELADDR=y
>
> Also, it seems that the "select USE_OF" went away with the board code
> Kconfig bits. I will send a patch for that right away.
Thanks. USE_OF + CONFIG_AUTO_ZRELADDR appears to work :)
next prev parent reply other threads:[~2013-11-08 23:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 23:21 [PATCH 00/04] ARM: shmobile: KZM9D legacy board code removal Magnus Damm
2013-11-06 23:21 ` Magnus Damm
2013-11-06 23:21 ` [PATCH 01/04] ARM: shmobile: Add shared EMEV2 code for ->init_machine() Magnus Damm
2013-11-06 23:21 ` Magnus Damm
2013-11-06 23:21 ` [PATCH 02/04] ARM: shmobile: Use ->init_late() in shared EMEV2 case Magnus Damm
2013-11-06 23:21 ` Magnus Damm
2013-11-06 23:21 ` [PATCH 03/04] ARM: shmobile: Remove legacy KZM9D board code Magnus Damm
2013-11-06 23:21 ` Magnus Damm
2013-11-08 8:49 ` Simon Horman
2013-11-08 8:49 ` Simon Horman
2013-11-08 10:03 ` Magnus Damm
2013-11-08 10:03 ` Magnus Damm
2013-11-08 23:34 ` Simon Horman [this message]
2013-11-08 23:34 ` Simon Horman
2013-11-06 23:21 ` [PATCH 04/04] ARM: shmobile: Remove legacy platform devices from EMEV2 SoC code Magnus Damm
2013-11-06 23:21 ` Magnus Damm
2013-11-08 7:52 ` [PATCH 00/04] ARM: shmobile: KZM9D legacy board code removal Simon Horman
2013-11-08 7:52 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108233409.GC4017@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.