From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Waiman Long <Waiman.Long@hp.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
George Spelvin <linux@horizon.com>,
"Aswin Chandramouleeswaran\"" <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH v5 4/4] qrwlock: Use the mcs_spinlock helper functions for MCS queuing
Date: Fri, 8 Nov 2013 19:07:18 -0800 [thread overview]
Message-ID: <20131109030718.GN18245@linux.vnet.ibm.com> (raw)
In-Reply-To: <1383959827.11046.420.camel@schen9-DESK>
On Fri, Nov 08, 2013 at 05:17:07PM -0800, Tim Chen wrote:
> On Fri, 2013-11-08 at 13:21 -0800, Paul E. McKenney wrote:
> > On Mon, Nov 04, 2013 at 12:17:20PM -0500, Waiman Long wrote:
> > > There is a pending patch in the rwsem patch series that adds a generic
> > > MCS locking helper functions to do MCS-style locking. This patch
> > > will enable the queue rwlock to use that generic MCS lock/unlock
> > > primitives for internal queuing. This patch should only be merged
> > > after the merging of that generic MCS locking patch.
> > >
> > > Signed-off-by: Waiman Long <Waiman.Long@hp.com>
> >
> > This one does might address at least some of the earlier memory-barrier
> > issues, at least assuming that the MCS lock is properly memory-barriered.
>
> Paul, will appreciate if you can take a look the latest version
> of MCS lock with load-acquire and store-release to see if it is now
> properly memory-barriered.
Don't worry, you cannot escape. It is on my list. ;-)
Thanx, Paul
prev parent reply other threads:[~2013-11-09 3:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 17:17 [PATCH v5 0/4] qrwlock: Introducing a queue read/write lock implementation Waiman Long
2013-11-04 17:17 ` [PATCH v5 1/4] qrwlock: A " Waiman Long
2013-11-08 21:11 ` Paul E. McKenney
2013-11-08 22:36 ` Waiman Long
2013-11-08 22:36 ` Waiman Long
2013-11-08 23:51 ` Paul E. McKenney
2013-11-09 3:05 ` Waiman Long
2013-11-04 17:17 ` [PATCH v5 2/4] qrwlock x86: Enable x86 to use queue read/write lock Waiman Long
2013-11-04 17:17 ` [PATCH v5 3/4] qrwlock: Enable fair " Waiman Long
2013-11-04 17:17 ` [PATCH v5 4/4] qrwlock: Use the mcs_spinlock helper functions for MCS queuing Waiman Long
2013-11-08 21:21 ` Paul E. McKenney
2013-11-08 22:42 ` Waiman Long
2013-11-08 22:42 ` Waiman Long
2013-11-09 1:17 ` Tim Chen
2013-11-09 3:07 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131109030718.GN18245@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Waiman.Long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.