From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Levente Kurusa <levex@linux.com>
Cc: Mark Brown <broonie@kernel.org>,
Caizhiyong <caizhiyong@hisilicon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wanglin (Albert)" <albert.wanglin@hisilicon.com>
Subject: Re: [PATCH] regmap: Fix compile warning with value uninitialized
Date: Sat, 9 Nov 2013 08:15:13 -0800 [thread overview]
Message-ID: <20131109161513.GD22695@kroah.com> (raw)
In-Reply-To: <527E55EF.5080504@linux.com>
On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote:
> 2013-11-09 16:16 keltezéssel, Mark Brown írta:
> > On Sat, Nov 09, 2013 at 09:49:11AM +0000, Caizhiyong wrote:
> >
> >> @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs,
> >> int num_regs)
> >> {
> >> struct reg_default *p;
> >> - int i, ret;
> >> + int i;
> >> + int ret = 0;
> >> bool bypass;
> Wouldn't the following be better?
>
> int i, ret = 0;
>
> I think it is more readable.
No, please put them on separate lines like the patch did.
next prev parent reply other threads:[~2013-11-09 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 9:49 [PATCH] regmap: Fix compile warning with value uninitialized Caizhiyong
2013-11-09 15:16 ` Mark Brown
2013-11-09 15:34 ` Levente Kurusa
2013-11-09 16:15 ` Greg Kroah-Hartman [this message]
2013-11-09 18:57 ` Mark Brown
2013-11-09 19:02 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131109161513.GD22695@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=albert.wanglin@hisilicon.com \
--cc=broonie@kernel.org \
--cc=caizhiyong@hisilicon.com \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.