All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] Non-trivial merge conflicts between u-boot/master and u-boot-arm/master
Date: Sat, 9 Nov 2013 18:49:01 +0100	[thread overview]
Message-ID: <20131109184901.42347c29@lilith> (raw)
In-Reply-To: <20131109164735.GK5925@bill-the-cat>

Hi Tom,

On Sat, 9 Nov 2013 11:47:35 -0500, Tom Rini <trini@ti.com> wrote:

> On Sat, Nov 09, 2013 at 02:11:15PM +0100, Albert ARIBAUD wrote:
> > Hello,
> > 
> > While preparing my pull request from ARM to mainline, I've tried a
> > merge of u-boot-arm/master and u-boot/master and had to solve a few
> > non-trivial conflicts due to the kbuild stuff.
> > 
> > I wonder how I should proceed now. Should I simply submit the PR and
> > warn Tom that conflicts will arise, and indicate how I solved them?
> > I'd do (and I've done) that for trivial cases, but for non-trivial
> > changes it seems error-prone.
> > 
> > Plus, I have already performed the resolutions, so why waster Tom's
> > time? I could forward u-boot-arm/master to the merge commit, then
> > submit a fast-forward PR to u-boot/master.
> > 
> > But then, the changes I did will remain un-reviewed or maybe even
> > unnoticed.
> > 
> > I also thought I could treat this as a normal patch and submit it to the
> > ML... Only git won't generate a "patch" for merge commits, and I don't
> > know how patchwork will react to this.
> > 
> > So... any advice?
> 
> Include the resolution in the PR, and include the not-a-diff-exactly
> that git will generate, include that in the PR.

Which 'not-a-diff-exactly' do you mean?

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-11-09 17:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-09 13:11 [U-Boot] Non-trivial merge conflicts between u-boot/master and u-boot-arm/master Albert ARIBAUD
2013-11-09 16:47 ` Tom Rini
2013-11-09 17:49   ` Albert ARIBAUD [this message]
2013-11-09 19:50     ` Tom Rini
2013-11-09 20:53       ` Albert ARIBAUD
2013-11-10 17:52       ` Gerhard Sittig
2013-11-11 15:03         ` Tom Rini
2013-11-09 20:57   ` Albert ARIBAUD
2013-11-09 21:01     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131109184901.42347c29@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.