From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfUNx-0004OM-S8 for qemu-devel@nongnu.org; Sun, 10 Nov 2013 07:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VfUNr-0002qA-TI for qemu-devel@nongnu.org; Sun, 10 Nov 2013 07:45:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfUNr-0002p9-LE for qemu-devel@nongnu.org; Sun, 10 Nov 2013 07:44:55 -0500 Date: Sun, 10 Nov 2013 14:47:46 +0200 From: "Michael S. Tsirkin" Message-ID: <20131110124746.GA7602@redhat.com> References: <1384085725-23522-1-git-send-email-marcel.a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384085725-23522-1-git-send-email-marcel.a@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-1.7 0/2] revert master abort related patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: agraf@suse.de, ehabkost@redhat.com, peter.maydell@linaro.org, jan.kiszka@siemens.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de, rth@twiddle.net On Sun, Nov 10, 2013 at 02:15:23PM +0200, Marcel Apfelbaum wrote: > The master-abort patch introduced a background memory region > covering all 64 bit pci address space, the visible parts > being the unused pci-holes addresses. > > The patch revealed the following issues: > 1. Some memory regions have INT64_MAX size, but the size > was supposed to be UINT64_MAX (meaning that the > region covers all 64 bit address space). Having > a region that is not even a multiple of PAGE_SIZE > is really not what we want. > 2. exec.c does not support all the 64 bit address range > and when using an unsupported address, it leads to > page tables corruption. > 3. Some memory regions overlap and the visible region > is selected by chance (the algorithm implementation) > and not by the memory API: > - selecting a proper priority > - arrange the regions that are not supposed to overlap. > > This series reverts this patch and another related patch > because the impact for 1.7 is too big. > After the issues above are solved, the patch can finally > be applied. I edited the commit log slightly and applied this, thanks. > Marcel Apfelbaum (1): > Revert "hw/pci: partially handle pci master abort" > > Michael S. Tsirkin (1): > Revert "exec: limit system memory size" > > exec.c | 7 +------ > hw/pci/pci.c | 26 -------------------------- > include/hw/pci/pci_bus.h | 1 - > 3 files changed, 1 insertion(+), 33 deletions(-) > > -- > 1.8.3.1