From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200Ab3KKKyO (ORCPT ); Mon, 11 Nov 2013 05:54:14 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:36986 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942Ab3KKKyE (ORCPT ); Mon, 11 Nov 2013 05:54:04 -0500 Date: Mon, 11 Nov 2013 10:53:56 +0000 From: Lee Jones To: Chanwoo Choi Cc: Charles Keepax , myungjoo.ham@samsung.com, sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels Message-ID: <20131111105356.GB22184@lee--X1> References: <1383916783-17921-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <5280AAAF.8040005@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5280AAAF.8040005@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 11/08/2013 10:19 PM, Charles Keepax wrote: > > Improve readability by creating a define for each microphone detection > > level. > > > > Signed-off-by: Charles Keepax > > --- > > drivers/extcon/extcon-arizona.c | 21 ++++++++++++++++----- > > include/linux/mfd/arizona/registers.h | 9 +++++++++ > > 2 files changed, 25 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > > index 3c55ec8..6d914ba 100644 > > --- a/drivers/extcon/extcon-arizona.c > > +++ b/drivers/extcon/extcon-arizona.c > > @@ -44,6 +44,17 @@ > > #define HPDET_DEBOUNCE 500 > > #define DEFAULT_MICD_TIMEOUT 2000 > > > > +enum { > > + MICD_LVL_1_TO_7 = ARIZONA_MICD_LVL_1 | ARIZONA_MICD_LVL_2 | > > + ARIZONA_MICD_LVL_3 | ARIZONA_MICD_LVL_4 | > > + ARIZONA_MICD_LVL_5 | ARIZONA_MICD_LVL_6 | > > + ARIZONA_MICD_LVL_7, > > + > > + MICD_LVL_0_TO_7 = ARIZONA_MICD_LVL_0 | MICD_LVL_1_TO_7, > > + > > + MICD_LVL_0_TO_8 = MICD_LVL_0_TO_7 | ARIZONA_MICD_LVL_8, > > +}; > > MICD_LVL_1_TO_7 / MICD_LVL_0_TO_7 /MICD_LVL_0_TO_8 haven't the sequential value. > I prefer '#define' keyword to define MICD_LVL_1_TO_7 / MICD_LVL_0_TO_7 /MICD_LVL_0_TO_8 > instead of enum keyword. Actually Charles has already sent me this patch and I applied it a while ago. I'm inclined to agree with you though, so if you want to send a patch based on v3.14-rc1 I'd be happy to accept it. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog