From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: dfu: make nand upload working
Date: Mon, 11 Nov 2013 14:29:38 +0100 [thread overview]
Message-ID: <201311111429.38965.marex@denx.de> (raw)
In-Reply-To: <528092AF.4050901@atmel.com>
Dear Bo Shen,
> Hi Heiko,
>
> On 11/11/2013 02:46 PM, Heiko Schocher wrote:
> > Hello Lukasz,
> >
> > Am 08.11.2013 16:41, schrieb Lukasz Majewski:
> >> Hi Bo,
> >>
> >>> Nowhere pass a value to len, which always 0, make no transfer which
> >>> cause uploading failed.
> >>>
> >>> This patch make nand upload working. However it needs enough malloc
> >>> buffer to store read data, that means the buffer at least equal to
> >>> the upload partition size, or else it doesn't work.
> >>>
> >>> Signed-off-by: Bo Shen<voice.shen@atmel.com>
> >>
> >> I would kindly ask some users of NAND part of the DFU (Tom, Heiko) to
> >> test if this change doesn't break anything.
> >
> > I sent a tested-by for this patch, see:
> >
> > http://lists.denx.de/pipermail/u-boot/2013-November/166552.html
> >
> > without this patch nand upload didn;t worked on the rut board, with
> > this patch it worked :-)
>
> Thanks for testing it.
Thanks guys, PR is already on it's way to mainline.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-11-11 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 6:29 [U-Boot] [PATCH v2] usb: dfu: make nand upload working Bo Shen
2013-11-08 12:14 ` Heiko Schocher
2013-11-08 15:41 ` Lukasz Majewski
2013-11-11 6:46 ` Heiko Schocher
2013-11-11 8:17 ` Bo Shen
2013-11-11 13:29 ` Marek Vasut [this message]
2013-11-08 19:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311111429.38965.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.