From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf tool: Round mmap pages to power 2
Date: Mon, 11 Nov 2013 11:59:08 -0300 [thread overview]
Message-ID: <20131111145908.GC27198@ghostprotocols.net> (raw)
In-Reply-To: <20131111112754.GD15810@gmail.com>
Em Mon, Nov 11, 2013 at 12:27:54PM +0100, Ingo Molnar escreveu:
> * David Ahern <dsahern@gmail.com> wrote:
>
> > Currently perf requires the -m / --mmap_pages option to be a power of 2.
> > To be more user friendly perf should automatically round this up to the
> > next power of 2.
> >
> > Currently:
> > $ perf record -m 3 -a -- sleep 1
> > --mmap_pages/-m value must be a power of two.sleep: Terminated
> >
> > With patch:
> > $ perf record -m 3 -a -- sleep 1
> > rounding mmap pages size to 16384 (4 pages)
>
> Please add 'bytes'.
Ok, waiting for v2 with this and Adrian's concerns addressed.
- Arnaldo
prev parent reply other threads:[~2013-11-11 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 4:36 [PATCH] perf tool: Round mmap pages to power 2 David Ahern
2013-11-08 9:11 ` Adrian Hunter
2013-11-08 14:41 ` David Ahern
2013-11-11 7:55 ` Adrian Hunter
2013-11-11 11:27 ` Ingo Molnar
2013-11-11 14:59 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111145908.GC27198@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.