From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfsRL-0002Nx-1W for qemu-devel@nongnu.org; Mon, 11 Nov 2013 09:26:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VfsRG-0006Sf-HO for qemu-devel@nongnu.org; Mon, 11 Nov 2013 09:26:06 -0500 Date: Mon, 11 Nov 2013 15:25:46 +0100 From: Igor Mammedov Message-ID: <20131111152546.4be13e10@thinkpad> In-Reply-To: <5280D061.50802@suse.de> References: <1384155875-26999-1-git-send-email-aik@ozlabs.ru> <1384155875-26999-5-git-send-email-aik@ozlabs.ru> <5280D061.50802@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: Alexander Graf , Alexey Kardashevskiy , Jan Kiszka , qemu-devel@nongnu.org, Luiz Capitulino , qemu-ppc@nongnu.org, Anthony Liguori On Mon, 11 Nov 2013 13:41:05 +0100 Andreas F=E4rber wrote: > Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: > > This converts +foo/-foo to "foo=3Don"/"foo=3Doff" respectively when > > QEMU parser is used for the command line options. > >=20 > > "-cpu" parsers in x86 and other architectures should be unaffected > > by this change. > >=20 > > Signed-off-by: Alexey Kardashevskiy > > --- > > util/qemu-option.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > >=20 > > diff --git a/util/qemu-option.c b/util/qemu-option.c > > index efcb5dc..6c8667c 100644 > > --- a/util/qemu-option.c > > +++ b/util/qemu-option.c > > @@ -890,6 +890,12 @@ static int opts_do_parse(QemuOpts *opts, const cha= r *params, > > if (strncmp(option, "no", 2) =3D=3D 0) { > > memmove(option, option+2, strlen(option+2)+1); > > pstrcpy(value, sizeof(value), "off"); > > + } else if (strncmp(option, "-", 1) =3D=3D 0) { > > + memmove(option, option+1, strlen(option+1)+1); > > + pstrcpy(value, sizeof(value), "off"); > > + } else if (strncmp(option, "+", 1) =3D=3D 0) { > > + memmove(option, option+1, strlen(option+1)+1); > > + pstrcpy(value, sizeof(value), "on"); > > } else { > > pstrcpy(value, sizeof(value), "on"); > > } >=20 > This looks like an interesting idea! However this is much too big a > change to just CC ppc folks on... >=20 > Jan, I wonder if this might break slirp's hostfwd option? >=20 > Not sure what other options potentially starting with '-' might be > affected. Test cases would be a helpful way of demonstrating that this > change does not have undesired side effects. on x86 there is several value fixups for compatibility reason and a manual value parsing in cpu_x86_parse_featurestr(), so above won't just work there. >=20 > Regards, > Andreas >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg >=20 --=20 Regards, Igor