From: Guenter Roeck <linux@roeck-us.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] watchdog: pcwd_usb: overflow in usb_pcwd_send_command()
Date: Mon, 11 Nov 2013 16:00:21 +0000 [thread overview]
Message-ID: <20131111160021.GA24135@roeck-us.net> (raw)
In-Reply-To: <20131108092419.GA22389@elgon.mountain>
On Fri, Nov 08, 2013 at 01:24:19AM -0800, Dan Carpenter wrote:
> We changed "buf" from being an array of 6 chars to being a pointer this
> sizeof(buf) needs to be updated as well.
>
> Fixes: 2ddb8089a7e5 ('watchdog: pcwd_usb: Use allocated buffer for usb_control_msg')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
I thought I had replied earlier, but I don't find my reply anywhere.
My apologies if this is a duplicate.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] watchdog: pcwd_usb: overflow in usb_pcwd_send_command()
Date: Mon, 11 Nov 2013 08:00:21 -0800 [thread overview]
Message-ID: <20131111160021.GA24135@roeck-us.net> (raw)
In-Reply-To: <20131108092419.GA22389@elgon.mountain>
On Fri, Nov 08, 2013 at 01:24:19AM -0800, Dan Carpenter wrote:
> We changed "buf" from being an array of 6 chars to being a pointer this
> sizeof(buf) needs to be updated as well.
>
> Fixes: 2ddb8089a7e5 ('watchdog: pcwd_usb: Use allocated buffer for usb_control_msg')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
I thought I had replied earlier, but I don't find my reply anywhere.
My apologies if this is a duplicate.
Guenter
next prev parent reply other threads:[~2013-11-11 16:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 7:40 [patch] watchdog: pcwd_usb: overflow in usb_pcwd_send_command() Dan Carpenter
2013-11-07 7:40 ` Dan Carpenter
2013-11-07 7:47 ` Wim Van Sebroeck
2013-11-07 7:47 ` Wim Van Sebroeck
2013-11-07 14:27 ` Guenter Roeck
2013-11-07 14:27 ` Guenter Roeck
2013-11-07 14:33 ` Dan Carpenter
2013-11-07 14:33 ` Dan Carpenter
2013-11-08 9:24 ` [patch v2] " Dan Carpenter
2013-11-08 9:24 ` Dan Carpenter
2013-11-08 14:24 ` Guenter Roeck
2013-11-08 14:24 ` Guenter Roeck
2013-11-11 16:00 ` Guenter Roeck [this message]
2013-11-11 16:00 ` Guenter Roeck
2013-11-17 19:06 ` Wim Van Sebroeck
2013-11-17 19:06 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111160021.GA24135@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.