From: Simon Wunderlich <sw@simonwunderlich.de>
To: "Coelho, Luciano" <luciano.coelho@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: [RFC v3 1/4] mac80211: don't transmit beacon with CSA count 0
Date: Tue, 12 Nov 2013 12:04:33 +0100 [thread overview]
Message-ID: <201311121204.33274.sw@simonwunderlich.de> (raw)
In-Reply-To: <1384244496.12583.46.camel@porter.coelho.fi>
> > Just to make future bisecting easier, shouldn't this patch go after "only
> > set CSA beacon when at least one beacon must be transmitted" in the
> > series? Otherwise userspace may change the channel with count=0 and hit
> > a warning here, because this is not supported anymore.
>
> My plan was to squash them, because they really belong together. What
> do you think?
>
Good idea, it belongs together anyway.
> > Apart from that, the series looks fine. I'd like to test the next v4
> > then.
>
> Great! I'll try to send v4 soon, hopefully the missing mesh part doesn't
> turn out to be too complicated. ;)
OK
> > I guess we still need to do the action frame part - for IBSS mode we
> > already have code but we probably need to make sure that these packets
> > go out before actually changing the channel. Do you plan to work on
> > that?
>
> Yes, I'll look into it. I think it should be pretty simple, especially
> now that we already have IBSS and MESH sending it out.
Great, thanks!
Simon
prev parent reply other threads:[~2013-11-12 11:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 14:39 [RFC v3 1/4] mac80211: don't transmit beacon with CSA count 0 Luciano Coelho
2013-11-08 14:39 ` [RFC v3 2/4] mac80211: refactor ieee80211_ibss_process_chanswitch() Luciano Coelho
2013-11-08 14:39 ` [RFC v3 3/4] mac80211: align ieee80211_ibss_csa_beacon() with ieee80211_csa_beacon() Luciano Coelho
2013-11-08 14:39 ` [RFC v3 4/4] mac80211: only set CSA beacon when at least one beacon must be transmitted Luciano Coelho
2013-11-08 14:42 ` [RFC v3 1/4] mac80211: don't transmit beacon with CSA count 0 Luca Coelho
2013-11-11 13:59 ` Johannes Berg
2013-11-12 8:09 ` Coelho, Luciano
2013-11-11 14:57 ` Simon Wunderlich
2013-11-12 8:22 ` Coelho, Luciano
2013-11-12 11:04 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311121204.33274.sw@simonwunderlich.de \
--to=sw@simonwunderlich.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.