From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() Date: Tue, 12 Nov 2013 15:26:49 +0200 Message-ID: <20131112132649.GC2008@redhat.com> References: <1384204922-8250-1-git-send-email-peter.maydell@linaro.org> <5281580D.7060305@redhat.com> <52816422.8060002@redhat.com> <52821A62.2050001@redhat.com> <52822958.8060508@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , Anthony Liguori , QEMU Developers , kvm-devel , Patch Tracking , Andreas Tobler , Anthony Liguori To: Peter Maydell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46901 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755246Ab3KLN0y (ORCPT ); Tue, 12 Nov 2013 08:26:54 -0500 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Nov 12, 2013 at 01:21:51PM +0000, Peter Maydell wrote: > (Similarly, > you can put code that's a syntax error inside #if 0, > but that won't work inside an "if (0)". The solution > is not to do that.) > That's the advantage of using "if (0)" instead of #if 0. You do not need to enable insane amount of options to check that your change does not break complication for any of them. -- Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgDzg-0004GX-Fx for qemu-devel@nongnu.org; Tue, 12 Nov 2013 08:27:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgDza-0007va-GO for qemu-devel@nongnu.org; Tue, 12 Nov 2013 08:27:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgDza-0007vJ-9C for qemu-devel@nongnu.org; Tue, 12 Nov 2013 08:26:54 -0500 Date: Tue, 12 Nov 2013 15:26:49 +0200 From: Gleb Natapov Message-ID: <20131112132649.GC2008@redhat.com> References: <1384204922-8250-1-git-send-email-peter.maydell@linaro.org> <5281580D.7060305@redhat.com> <52816422.8060002@redhat.com> <52821A62.2050001@redhat.com> <52822958.8060508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , kvm-devel , Patch Tracking , QEMU Developers , Andreas Tobler , Anthony Liguori , Paolo Bonzini On Tue, Nov 12, 2013 at 01:21:51PM +0000, Peter Maydell wrote: > (Similarly, > you can put code that's a syntax error inside #if 0, > but that won't work inside an "if (0)". The solution > is not to do that.) > That's the advantage of using "if (0)" instead of #if 0. You do not need to enable insane amount of options to check that your change does not break complication for any of them. -- Gleb.