From mboxrd@z Thu Jan 1 00:00:00 1970 From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk) Date: Tue, 12 Nov 2013 09:45:00 -0500 Subject: [Xen-devel] [PATCH 1/2] swiotlb-xen: add missing xen_dma_map_page call In-Reply-To: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com> References: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com> Message-ID: <20131112144500.GB9435@phenom.dumpdata.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 12, 2013 at 02:11:59PM +0000, Stefano Stabellini wrote: > swiotlb-xen is missing a xen_dma_map_page call in > xen_swiotlb_map_sg_attrs, in the slow path. s/slow/bounce buffer/ I believe? > > Signed-off-by: Stefano Stabellini > --- > drivers/xen/swiotlb-xen.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > index a224bc7..1eac073 100644 > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > sg_dma_len(sgl) = 0; > return 0; > } > + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT), > + map & ~PAGE_MASK, > + sg->length, > + dir, > + attrs); > sg->dma_address = xen_phys_to_bus(map); > } else { > /* we are not interested in the dma_addr returned by > -- > 1.7.2.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel at lists.xen.org > http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755349Ab3KLOqj (ORCPT ); Tue, 12 Nov 2013 09:46:39 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:48599 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280Ab3KLOqh (ORCPT ); Tue, 12 Nov 2013 09:46:37 -0500 Date: Tue, 12 Nov 2013 09:45:00 -0500 From: Konrad Rzeszutek Wilk To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, konrad@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Xen-devel] [PATCH 1/2] swiotlb-xen: add missing xen_dma_map_page call Message-ID: <20131112144500.GB9435@phenom.dumpdata.com> References: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 12, 2013 at 02:11:59PM +0000, Stefano Stabellini wrote: > swiotlb-xen is missing a xen_dma_map_page call in > xen_swiotlb_map_sg_attrs, in the slow path. s/slow/bounce buffer/ I believe? > > Signed-off-by: Stefano Stabellini > --- > drivers/xen/swiotlb-xen.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > index a224bc7..1eac073 100644 > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > sg_dma_len(sgl) = 0; > return 0; > } > + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT), > + map & ~PAGE_MASK, > + sg->length, > + dir, > + attrs); > sg->dma_address = xen_phys_to_bus(map); > } else { > /* we are not interested in the dma_addr returned by > -- > 1.7.2.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH 1/2] swiotlb-xen: add missing xen_dma_map_page call Date: Tue, 12 Nov 2013 09:45:00 -0500 Message-ID: <20131112144500.GB9435@phenom.dumpdata.com> References: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1384265520-6833-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Stefano Stabellini Cc: konrad@kernel.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: xen-devel@lists.xenproject.org On Tue, Nov 12, 2013 at 02:11:59PM +0000, Stefano Stabellini wrote: > swiotlb-xen is missing a xen_dma_map_page call in > xen_swiotlb_map_sg_attrs, in the slow path. s/slow/bounce buffer/ I believe? > > Signed-off-by: Stefano Stabellini > --- > drivers/xen/swiotlb-xen.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > index a224bc7..1eac073 100644 > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > sg_dma_len(sgl) = 0; > return 0; > } > + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT), > + map & ~PAGE_MASK, > + sg->length, > + dir, > + attrs); > sg->dma_address = xen_phys_to_bus(map); > } else { > /* we are not interested in the dma_addr returned by > -- > 1.7.2.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel