From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] ixgbe: Fix offloading bits when RX bulk
	alloc is used.
Date: Tue, 12 Nov 2013 18:21:52 +0100
Message-ID: <201311121821.53077.thomas.monjalon@6wind.com>
References: <1383940042-31770-1-git-send-email-bmbenson@amazon.com>
 <52824E21.20405@6wind.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Bryan Benson <bmbenson-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <52824E21.20405-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

12/11/2013 16:49, Ivan Boule :
> On 11/08/2013 08:47 PM, Bryan Benson wrote:
> > This is a fix for the ixgbe hardware offload flags not being set when
> > bulk alloc RX is used. The issue was caused by masking off the bits that
> > store the hardware offload values in the status_error field to retrieve
> > the done bit for the descriptor.
> > 
> > Commit 7431041062b9fd0555bac7ca4abebc99e3379fa5 in DPDK-1.3.0 introduced
> > bulk dequeue, which included the bug. ---
> > 
> >   lib/librte_pmd_ixgbe/ixgbe_rxtx.c |   13 +++++++------
> >   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> Acked.

Applied.

Good catch. Thanks
-- 
Thomas