From: Vinod Koul <vinod.koul@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] dma: pl330: off by one in pl330_probe()
Date: Wed, 13 Nov 2013 13:32:30 +0000 [thread overview]
Message-ID: <20131113132030.GY8834@intel.com> (raw)
In-Reply-To: <20131108095024.GH27977@elgon.mountain>
On Fri, Nov 08, 2013 at 12:50:24PM +0300, Dan Carpenter wrote:
> There are only AMBA_NR_IRQS (2) elements in adev->irq[]. This code
> maybe works if the there is a zero directly after the array.
Applied both
Thanks
~Vinod
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 4b2583c..4af4b0c 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2926,7 +2926,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
>
> amba_set_drvdata(adev, pdmac);
>
> - for (i = 0; i <= AMBA_NR_IRQS; i++) {
> + for (i = 0; i < AMBA_NR_IRQS; i++) {
> irq = adev->irq[i];
> if (irq) {
> ret = devm_request_irq(&adev->dev, irq,
--
prev parent reply other threads:[~2013-11-13 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 9:50 [patch 1/2] dma: pl330: off by one in pl330_probe() Dan Carpenter
2013-11-13 13:32 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113132030.GY8834@intel.com \
--to=vinod.koul@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.