From: Mark Brown <broonie@kernel.org>
To: Gerlando Falauto <gerlando.falauto@keymile.com>
Cc: linux-kernel@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH] spi: spi-gpio: Add check for cs-gpios dt property
Date: Wed, 13 Nov 2013 13:33:20 +0000 [thread overview]
Message-ID: <20131113133320.GL878@sirena.org.uk> (raw)
In-Reply-To: <1384329748-2897-1-git-send-email-gerlando.falauto@keymile.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Wed, Nov 13, 2013 at 09:02:28AM +0100, Gerlando Falauto wrote:
> The bindings assumed that the cs-gpios property is always there.
> However, a single SPI device can also work fine without an explicit chip select.
> Use the SPI_GPIO_NO_CHIPSELECT mode when the property is not present or invaild.
Given that for most systems a missing /CS would be an error it seems
better to add an explicit property to enable this in order to help make
problems with the more common case more obvious.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-13 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 8:02 [PATCH] spi: spi-gpio: Add check for cs-gpios dt property Gerlando Falauto
2013-11-13 13:33 ` Mark Brown [this message]
2013-11-13 14:33 ` Gerlando Falauto
2013-11-13 14:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113133320.GL878@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gerlando.falauto@keymile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.