From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 1/7] drm: Add DSI bus infrastructure Date: Wed, 13 Nov 2013 22:38:59 +0100 Message-ID: <20131113213856.GA10856@mithrandir> References: <1384171235-2498-1-git-send-email-treding@nvidia.com> <1384171235-2498-2-git-send-email-treding@nvidia.com> <528237BE.8020501@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1659704692==" Return-path: Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com [209.85.214.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EBE2F9F69 for ; Wed, 13 Nov 2013 13:39:06 -0800 (PST) Received: by mail-bk0-f46.google.com with SMTP id e11so645866bkh.19 for ; Wed, 13 Nov 2013 13:39:03 -0800 (PST) In-Reply-To: <528237BE.8020501@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Andrzej Hajda Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1659704692== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline --SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 12, 2013 at 03:14:22PM +0100, Andrzej Hajda wrote: > Hi Thierry, >=20 > I have already sent patch with DSI bus implementation [1]. > It was posted as the first step of CDF implementation attempt, > but in fact it do not depend on CDF. >=20 > [1] > http://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg45252.html Seems like that patchset was never merged. I guess probably because it was posted as part of CDF work. Do you have any plans on continuing work on that? If not I could extract the DSI bus patch from the series, it's largely similar to the patch I proposed here, and rework it somewhat. I'd very much like to avoid putting the code in drivers/video, though, since that's considered obsolete. Furthermore I think if we kept the transfer function proposed in my patch should make it easier to address Bert's comments from your posting. > One comment below. >=20 > On 11/11/2013 01:00 PM, Thierry Reding wrote: > > In order to support DSI peripherals, add a DSI bus type that devices and > > drivers can be registered with. > >=20 > > Signed-off-by: Thierry Reding > > --- >=20 > [snip] > > + > > +/* > > + * DSI packet data types > > + */ > > + > > +/* processor-sourced packets */ > > +#define DSI_CMD_VSYNC_START 0x01 > > +#define DSI_CMD_VSYNC_END 0x11 > > +#define DSI_CMD_HSYNC_START 0x21 > > +#define DSI_CMD_HSYNC_END 0x31 > > +#define DSI_CMD_EOT 0x08 > > +#define DSI_CMD_COLOR_MODE_OFF 0x02 > > +#define DSI_CMD_COLOR_MODE_ON 0x12 > > +#define DSI_CMD_SHUT_DOWN 0x22 > > +#define DSI_CMD_TURN_ON 0x32 > > +#define DSI_CMD_GEN_SHORT_WRITE_0 0x03 > > +#define DSI_CMD_GEN_SHORT_WRITE_1 0x13 > > +#define DSI_CMD_GEN_SHORT_WRITE_2 0x23 > > +#define DSI_CMD_GEN_SHORT_READ_0 0x04 > > +#define DSI_CMD_GEN_SHORT_READ_1 0x14 > > +#define DSI_CMD_GEN_SHORT_READ_2 0x24 > > +#define DSI_CMD_DCS_SHORT_WRITE_0 0x05 > > +#define DSI_CMD_DCS_SHORT_WRITE_1 0x15 > > +#define DSI_CMD_DCS_SHORT_READ 0x06 > > +#define DSI_CMD_SET_MAX_RETURN_PACKET_SIZE 0x37 > > +#define DSI_CMD_NULL 0x09 > > +#define DSI_CMD_BLANK 0x19 > > +#define DSI_CMD_GEN_LONG_WRITE 0x29 > > +#define DSI_CMD_DCS_LONG_WRITE 0x39 > > +#define DSI_CMD_YCbCr422_20 0x0c > > +#define DSI_CMD_YCbCr422_24 0x1c > > +#define DSI_CMD_YCbCr422_16 0x2c > > +#define DSI_CMD_RGB30 0x0d > > +#define DSI_CMD_RGB36 0x1d > > +#define DSI_CMD_YCbCr420 0x3d > > +#define DSI_CMD_RGB16 0x0e > > +#define DSI_CMD_RGB18 0x1e > > +#define DSI_CMD_RGB18NP 0x2e > > +#define DSI_CMD_RGB24 0x3e > > + > > +/* peripheral-sourced */ > > +#define DSI_RSP_ACK_ERR 0x02 > > +#define DSI_RSP_EOT 0x08 > > +#define DSI_RSP_GEN_SHORT_READ_1 0x11 > > +#define DSI_RSP_GEN_SHORT_READ_2 0x12 > > +#define DSI_RSP_GEN_LONG_READ 0x1a > > +#define DSI_RSP_DCS_LONG_READ 0x1c > > +#define DSI_RSP_DCS_SHORT_READ_1 0x21 > > +#define DSI_RSP_DCS_SHORT_READ_2 0x22 > > + >=20 > Those macros are already defined in include/video/mipi_display.h I wasn't aware, thanks for the pointer. It's somewhat unfortunate that that's in include/video, but judging by the git log, it has been there for quite a while. Thierry --SUOF0GtieIMvvwua Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSg/FwAAoJEN0jrNd/PrOh+/oP/2+ZX0Oyqoi+puVBPJLKKUDk h/rk/YDlOLq9szT0iCuX6eOTWMb+48gBciUwIvFcR6U4cFSc9pC7+4M7bBNpcpow iaJ9xU2/AT8XKW5vOqYonVvHBKhsYOOHCszSLerisYGFJwGtz/m/HOT647nQ9Cid uG9EZ8ZKOwpgv7Pvx+4cOCj47dJSJXpwffKiP5tX6AeC5OWy6N0MJhTaCIGDR8gX eFeXtfkB4OAkG0nZqbTjh6fJ0crNdS9r7+x+JAe3JD6qkU9sgDun8vXoScA1Lj8U dYb+ihJdIHQ9QrOqCbnkMlqGoevbfJJNSgMXcriPzNX1UTzCnXuM0gQRB+g5hluJ AaUdEQD3ADd+EZ33qLKIqR5AQ9JBV/QFjj/oReIeeidbB30nBTIx1YQUuJ8YkJHW wHUqI1ipZhO31DY4AQvHWz01DXa6SLUBAcaSBoN8UzniarmVR4n6cNQGdj/kvaAg NZB0uQ9epVduYSC/JSpjz40Mc42V6PAMfiiZUJ/FoEJaRCizFe0YfiSuTBiRsNV9 q85b5M4RnFdmRSD32Qitt5DJ+ZchwbOtHAk9s5ajQDdbuh3x++0yXXVLhCl0obaJ Jw39pLpxfJYGaixFS66sQP2IsF4lu5VIB4EnhSxUJuo2a4dv0kM48xzdP8Jb6pW5 LYlTLsAJ2DI9vhA3a6uX =1YEY -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua-- --===============1659704692== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1659704692==--