From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Changli Gao <xiaosuo@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Fix the format of /proc/net/nf_conntrack_expect
Date: Wed, 13 Nov 2013 23:50:44 +0100 [thread overview]
Message-ID: <20131113225044.GA4383@localhost> (raw)
In-Reply-To: <1384268886-6991-1-git-send-email-xiaosuo@gmail.com>
On Tue, Nov 12, 2013 at 11:08:06PM +0800, Changli Gao wrote:
> There should not be any white space around `='.
>
> ---
> net/netfilter/nf_conntrack_expect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
> index 4fd1ca9..151af72 100644
> --- a/net/netfilter/nf_conntrack_expect.c
> +++ b/net/netfilter/nf_conntrack_expect.c
> @@ -517,7 +517,7 @@ static int exp_seq_show(struct seq_file *s, void *v)
> ? (long)(expect->timeout.expires - jiffies)/HZ : 0);
> else
> seq_printf(s, "- ");
> - seq_printf(s, "l3proto = %u proto=%u ",
> + seq_printf(s, "l3proto=%u proto=%u ",
Yes, that doesn't look nice, but that output format is there since
2006 (introduced in 77ab9cff).
This is a legacy interface (we have ctnetlink and the conntrack
utility these days) and I don't want to break backward for
applications parsing that output. I'm not taking this.
prev parent reply other threads:[~2013-11-13 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 15:08 [PATCH] netfilter: Fix the format of /proc/net/nf_conntrack_expect Changli Gao
2013-11-13 22:50 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113225044.GA4383@localhost \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.