From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/kconfig: fix 'space' to (de)select options
Date: Wed, 13 Nov 2013 22:55:23 +0100 [thread overview]
Message-ID: <20131113225523.30f7eb69@skate> (raw)
In-Reply-To: <1384379593-32281-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Wed, 13 Nov 2013 22:53:13 +0100, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> In case a menu has comment without letters/numbers (eg. characters
> matching the regexp '^[^[:alpha:][:digit:]]+$', for example - or *),
> hitting space will cycle through those comments, rather than
> selecting/deselecting the currently-highlighted option.
>
> This is the behaviour of hitting any letter/digit: jump to the next
> option which prompt starts with that letter. The only letters that
> do not behave as such are 'y' 'm' and 'n'. Prompts that start with
> one of those three letters are instead matched on the first letter
> that is not 'y', 'm' or 'n'.
>
> Fix that by treating 'space' as we treat y/m/n, ie. as an action key,
> not as shortcut to jump to prompt.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <jacmet@uclibc.org>
> Cc: Samuel Martin <s.martin49@gmail.com>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> ---
> Note: I'll be running this upstream soonish.
Thanks?
> ---
> support/kconfig/lxdialog/menubox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Shouldn't we also update the patches in support/kconfig/patches/ ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-13 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 21:53 [Buildroot] [PATCH] support/kconfig: fix 'space' to (de)select options Yann E. MORIN
2013-11-13 21:55 ` Thomas Petazzoni [this message]
2013-11-13 21:59 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113225523.30f7eb69@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.