From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alvaro Neira <alvaroneay@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH 2/2] json: Refactor of exporting and parsing support flags
Date: Thu, 14 Nov 2013 00:46:44 +0100 [thread overview]
Message-ID: <20131113234643.GB28009@localhost> (raw)
In-Reply-To: <20131111200935.19419.8227.stgit@Ph0enix>
On Mon, Nov 11, 2013 at 09:09:35PM +0100, Alvaro Neira wrote:
> From: Álvaro Neira Ayuso <alvaroneay@gmail.com>
>
> Remove the different flag definition for using the snprinf
> and parsing support and create a new flags for joining in
> general flags.
>
> Now for printing or parsing tables or chains, we needed to use:
> NFT_TABLE_O_JSON
> NFT_TABLE_O_XML
> NFT_CHAIN_O_JSON
> NFT_CHAIN_O_XML
> NFT_CHAIN_PARSE_JSON
> NFT_TABLE_PARSE_JSON
> NFT_CHAIN_PARSE_XML
> NFT_TABLE_PARSE_XML
>
> Now for exporting and parsing rules and chains, we only use:
> NFT_FORMAT_JSON
> NFT_FORMAT_XML
> NFT_PARSE_FORMAT_JSON
> NFT_PARSE_FORMAT_XML
These names are too long. I mangled your patch to use:
NFT_OUTPUT_[XML|JSON]
NFT_PARSE_[XML|JSON]
instead.
I have also reworked the patch descriptions, it says "json: " but this
is not only related to it. Fixed and applied, thanks for working on this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-13 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 20:09 [libnftables PATCH 1/2] json: remove the rule flags in ruleset file Alvaro Neira
2013-11-11 20:09 ` [libnftables PATCH 2/2] json: Refactor of exporting and parsing support flags Alvaro Neira
2013-11-13 23:46 ` Pablo Neira Ayuso [this message]
2013-11-13 23:43 ` [libnftables PATCH 1/2] json: remove the rule flags in ruleset file Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113234643.GB28009@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.