From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Aaron Lu <aaron.lu@intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Lan Tianyu <tianyu.lan@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH 2/2] ACPI / bind: Use (put|get)_device() on ACPI device objects too
Date: Thu, 14 Nov 2013 11:43:48 +0900 [thread overview]
Message-ID: <20131114024348.GA9899@kroah.com> (raw)
In-Reply-To: <9712243.It8gvaRCs0@vostro.rjw.lan>
On Thu, Nov 14, 2013 at 12:26:47AM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> When associating a "physical" device with an ACPI device object
> acpi_bind_one() only uses get_device() to increment the reference
> counter of the former, but there is no reason not to do that with
> the latter too. Among other things, that may help to avoid
> use-after-free when an ACPI device object is freed without calling
> acpi_unbind_one() for all "physical" devices associated with it
> (that only can happen in buggy code, but then it's better if the
> kernel doesn't crash as a result of a bug).
>
> For this reason, modify acpi_bind_one() to apply get_device() to
> the ACPI device object too and update acpi_unbind_one() to drop
> that reference using put_device() as appropriate.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2013-11-14 2:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 0:58 [PATCH] ACPI / driver core: Store a device pointer in struct acpi_dev_node Rafael J. Wysocki
2013-11-10 15:16 ` Greg Kroah-Hartman
2013-11-11 1:21 ` Lan Tianyu
2013-11-11 13:45 ` Rafael J. Wysocki
2013-11-11 15:03 ` Greg Kroah-Hartman
2013-11-11 15:03 ` Greg Kroah-Hartman
2013-11-11 21:56 ` Rafael J. Wysocki
2013-11-11 21:56 ` Rafael J. Wysocki
2013-11-12 9:24 ` Mika Westerberg
2013-11-12 14:20 ` Rafael J. Wysocki
2013-11-13 6:57 ` Aaron Lu
2013-11-13 23:25 ` [PATCH 0/2] ACPI: Additional changes on top of "ACPI / driver core: Store a device pointer in struct acpi_dev_node" Rafael J. Wysocki
2013-11-13 23:26 ` [PATCH 1/2] ACPI: Eliminate the DEVICE_ACPI_HANDLE() macro Rafael J. Wysocki
2013-11-14 2:44 ` Greg Kroah-Hartman
2013-11-13 23:26 ` [PATCH 2/2] ACPI / bind: Use (put|get)_device() on ACPI device objects too Rafael J. Wysocki
2013-11-14 2:43 ` Greg Kroah-Hartman [this message]
2013-11-14 7:20 ` Lan Tianyu
2013-11-14 7:20 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114024348.GA9899@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaron.lu@intel.com \
--cc=bhelgaas@google.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=tianyu.lan@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.