From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Dave Frodin <dave.frodin@se-eng.com>,
Magnus Christensson <magnus.christensson@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: [Qemu-devel] [PATCH] acpi: strip compiler info in built-in DSDT
Date: Thu, 14 Nov 2013 14:01:16 +0200 [thread overview]
Message-ID: <20131114120116.GA4149@redhat.com> (raw)
IASL stores it's revision in each table header it generates.
That's not nice since guests will see a change each time
they move between hypervisors.
We generally fill our own info for tables,
but we (and seabios) forgot to do this for the built-in DSDT.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Probably not important enough for 1.7. Queued for 1.8.
hw/i386/acpi-build.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 486e705..8ae4f26 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -921,10 +921,16 @@ build_mcfg_q35(GArray *table_data, GArray *linker, AcpiMcfgInfo *info)
static void
build_dsdt(GArray *table_data, GArray *linker, AcpiMiscInfo *misc)
{
- void *dsdt;
+ AcpiTableHeader *dsdt;
+
assert(misc->dsdt_code && misc->dsdt_size);
+
dsdt = acpi_data_push(table_data, misc->dsdt_size);
memcpy(dsdt, misc->dsdt_code, misc->dsdt_size);
+
+ memset(dsdt, 0, sizeof *dsdt);
+ build_header(linker, table_data, dsdt, ACPI_DSDT_SIGNATURE,
+ misc->dsdt_size, 1);
}
/* Build final rsdt table */
--
MST
next reply other threads:[~2013-11-14 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 12:01 Michael S. Tsirkin [this message]
2013-11-14 13:45 ` [Qemu-devel] [PATCH] acpi: strip compiler info in built-in DSDT Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114120116.GA4149@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=dave.frodin@se-eng.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=magnus.christensson@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.