Re: [PATCH V2] ACPI, APEI: Cleanup alignment related codes for APEI

[Borislav Petkov <bp@alien8.de>]

On Wed, Nov 13, 2013 at 08:49:24PM -0500, Chen, Gong wrote:
> On Sun, Nov 10, 2013 at 09:07:46PM -0500, Chen, Gong wrote:
> > Date: Sun, 10 Nov 2013 21:07:46 -0500
> > From: "Chen, Gong" <gong.chen@linux.intel.com>
> > To: tony.luck@intel.com, bp@alien8.de
> > Cc: linux-acpi@vger.kernel.org, "Chen, Gong" <gong.chen@linux.intel.com>
> > Subject: [PATCH V2] ACPI, APEI: Cleanup alignment related codes for APEI
> > X-Mailer: git-send-email 1.8.4.rc3
> > 
> > We ever used *memcpy* to avoid access alignment issue between
> > firmware and OS. Now we can use a better and standard way
> > to avoid this issue. In the meanwhile, simplify some variable names
> > to avoid the limit of 80 characters per line and use structure
> > assignment instead of unnecessary memcpy. No functional changes.
> > 
> > v2->v1: Make description information clearer.
> > 
> Any comments? Boris/Tony?

I get this when building here:

drivers/acpi/apei/apei-base.c: In function ‘apei_check_gar’:
drivers/acpi/apei/apei-base.c:571:8: warning: assignment makes pointer from integer without a cast [enabled by default]
  paddr = get_unaligned(&reg->address);
        ^
drivers/acpi/apei/apei-base.c: In function ‘collect_res_callback’:
drivers/acpi/apei/apei-base.c:716:3: warning: ‘paddr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   return apei_res_add(&resources->iomem, paddr,
   ^
drivers/acpi/apei/apei-base.c: In function ‘apei_read’:
drivers/acpi/apei/apei-base.c:645:10: warning: ‘address’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   status = acpi_os_read_memory((acpi_physical_address) address,
          ^
drivers/acpi/apei/apei-base.c: In function ‘apei_write’:
drivers/acpi/apei/apei-base.c:678:10: warning: ‘address’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   status = acpi_os_write_memory((acpi_physical_address) address,

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html