From: Dave Jones <davej@redhat.com>
To: netdev@vger.kernel.org
Cc: oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa
Subject: netfilter: ipset: fix incorret comparison in hash_netnet4_data_equal()
Date: Thu, 14 Nov 2013 10:41:01 -0500 [thread overview]
Message-ID: <20131114154101.GA22625@redhat.com> (raw)
Both sides of the comparison are the same, looks like a cut-and-paste error.
Spotted by Coverity.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/net/netfilter/ipset/ip_set_hash_netnet.c b/net/netfilter/ipset/ip_set_hash_netnet.c
index 2bc2dec20b00..6226803fc490 100644
--- a/net/netfilter/ipset/ip_set_hash_netnet.c
+++ b/net/netfilter/ipset/ip_set_hash_netnet.c
@@ -59,7 +59,7 @@ hash_netnet4_data_equal(const struct hash_netnet4_elem *ip1,
u32 *multi)
{
return ip1->ipcmp == ip2->ipcmp &&
- ip2->ccmp == ip2->ccmp;
+ ip1->ccmp == ip2->ccmp;
}
static inline int
next reply other threads:[~2013-11-14 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 15:41 Dave Jones [this message]
2013-11-25 21:45 ` netfilter: ipset: fix incorret comparison in hash_netnet4_data_equal() Pablo Neira Ayuso
2013-12-07 12:23 ` Oliver
2013-12-07 19:53 ` Jozsef Kadlecsik
2013-12-07 22:34 ` Pablo Neira Ayuso
2013-12-08 9:31 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114154101.GA22625@redhat.com \
--to=davej@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.