From: "Pali Rohár" <pali.rohar@gmail.com>
To: Sebastian Reichel <sre@debian.org>
Cc: Tony Lindgren <tony@atomide.com>,
Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] isp1704_charger: Add DT support
Date: Thu, 14 Nov 2013 19:05:06 +0100 [thread overview]
Message-ID: <201311141905.11046@pali> (raw)
In-Reply-To: <1384432734-1490-1-git-send-email-sre@debian.org>
[-- Attachment #1: Type: Text/Plain, Size: 937 bytes --]
On Thursday 14 November 2013 13:38:53 Sebastian Reichel wrote:
> diff --git a/drivers/power/isp1704_charger.c
> b/drivers/power/isp1704_charger.c index fc04d19..db96778
> 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -28,6 +28,8 @@
> #include <linux/platform_device.h>
> #include <linux/power_supply.h>
> #include <linux/delay.h>
> +#include <linux/of.h>
> +#include <linux/of_gpio.h>
>
> #include <linux/usb/otg.h>
> #include <linux/usb/ulpi.h>
> @@ -89,8 +91,8 @@ static void isp1704_charger_set_power(struct
> isp1704_charger *isp, bool on) {
> struct isp1704_charger_data *board =
> isp->dev->platform_data;
>
> - if (board && board->set_power)
> - board->set_power(on);
> + if (board)
> + gpio_set_value(board->enable_gpio, on);
> }
>
You need to check if enable_gpio in board data was defined or not.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-11-14 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 12:38 [PATCH 1/2] isp1704_charger: Add DT support Sebastian Reichel
2013-11-14 12:38 ` [PATCH 2/2] dt: binding documentation for isp1704 charger Sebastian Reichel
2013-11-15 11:26 ` Mark Rutland
[not found] ` <1384432734-1490-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2013-11-14 17:52 ` [PATCH 1/2] isp1704_charger: Add DT support Tony Lindgren
2013-11-14 17:52 ` Tony Lindgren
2013-12-01 1:00 ` [PATCHv2 0/2] DT support for isp1704-charger Sebastian Reichel
2013-12-01 1:00 ` [PATCHv2 1/2] isp1704_charger: Add DT support Sebastian Reichel
2013-12-01 1:00 ` [PATCHv2 2/2] dt: binding documentation for isp1704 charger Sebastian Reichel
2013-12-24 2:35 ` [PATCHv2 0/2] DT support for isp1704-charger Anton Vorontsov
2013-11-14 18:05 ` Pali Rohár [this message]
2013-11-14 22:34 ` [PATCH 1/2] isp1704_charger: Add DT support Sebastian Reichel
2013-11-14 22:34 ` Sebastian Reichel
2013-11-15 6:45 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311141905.11046@pali \
--to=pali.rohar@gmail.com \
--cc=anton@enomsg.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=sre@debian.org \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.