From: Huang Shijie <shijie8@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Huang Shijie <b32955@freescale.com>,
computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
dwmw2@infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH 1/8] mtd: gpmi: do not use the local array to do the DMA transfer
Date: Thu, 14 Nov 2013 22:53:52 -0500 [thread overview]
Message-ID: <20131115035336.GB3904@gmail.com> (raw)
In-Reply-To: <20131114134630.GA7076@localhost>
On Thu, Nov 14, 2013 at 10:46:31AM -0300, Ezequiel Garcia wrote:
> On Thu, Nov 14, 2013 at 02:25:44PM +0800, Huang Shijie wrote:
>
> ONFI_SUBFEATURE_PARAM_LEN is only 4, so the most natural choice is to
> allocate that in the stack. I think you should add a comment here
> explaining that this buffer needs to be kmallocated for dma purposes.
>
> Just a nitpick, to avoid people asking why you're doing the allocation
> for just 4 bytes.
i just do not like the warning.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-11-14 14:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 6:25 [PATCH 0/8] the clean-up for gpmi Huang Shijie
2013-11-14 6:25 ` [PATCH 1/8] mtd: gpmi: do not use the local array to do the DMA transfer Huang Shijie
2013-11-14 13:46 ` Ezequiel Garcia
2013-11-15 3:53 ` Huang Shijie [this message]
2013-11-14 16:23 ` David Woodhouse
2013-11-15 2:14 ` Huang Shijie
2013-11-14 6:25 ` [PATCH 2/8] mtd: gpmi: delete the gpmi_pre_bbt_scan Huang Shijie
2013-11-14 6:25 ` [PATCH 3/8] mtd: gpmi: remove the unused line Huang Shijie
2013-11-14 6:25 ` [PATCH 4/8] mtd: gpmi: rename the functions from gpmi_nfc_* to gpmi_nand_* Huang Shijie
2013-11-14 6:25 ` [PATCH 5/8] mtd: gpmi: use devm_ioremap_resource Huang Shijie
2013-11-14 13:50 ` Ezequiel Garcia
2013-11-15 3:51 ` Huang Shijie
2013-11-14 6:25 ` [PATCH 6/8] mtd: gpmi: use devm_request_irq Huang Shijie
2013-11-14 6:25 ` [PATCH 7/8] mtd: gpmi: change pr_err to dev_err Huang Shijie
2013-11-18 20:23 ` Brian Norris
2013-11-19 2:30 ` Huang Shijie
2013-11-14 6:25 ` [PATCH 8/8] mtd: gpmi: change pr_debug to dev_dbg Huang Shijie
2013-11-18 20:24 ` Brian Norris
2013-11-18 20:25 ` [PATCH 0/8] the clean-up for gpmi Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115035336.GB3904@gmail.com \
--to=shijie8@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.