From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: perf code using smp_processor_id() in preemptible [00000000] code
Date: Fri, 15 Nov 2013 14:19:46 +0400 [thread overview]
Message-ID: <20131115101946.GG1754@moon> (raw)
In-Reply-To: <20131115100254.GC2965@twins.programming.kicks-ass.net>
On Fri, Nov 15, 2013 at 11:02:54AM +0100, Peter Zijlstra wrote:
> On Thu, Nov 14, 2013 at 10:29:07PM -0500, Dave Jones wrote:
> > BUG: using smp_processor_id() in preemptible [00000000] code: trinity-main/890
> > caller is p4_pmu_schedule_events+0x25/0x4c0
>
> Whee, wherever did you dig up that dinosaur ;-)
rofl ;)
>
> Hrmm, I'm not entire sure what we should do here; Cyrill, do you have clue?
We need figure out which cpu we're scheduled on to properly choose thread.
I have a vague memory that earlier I've raw_smp_processor_id here but then
someone pointed that we need smp_processor_id instead. Gimme some time,
I'll cook a patch today.
Thanks for report, Dave!
next prev parent reply other threads:[~2013-11-15 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 3:29 perf code using smp_processor_id() in preemptible [00000000] code Dave Jones
2013-11-15 10:02 ` Peter Zijlstra
2013-11-15 10:19 ` Cyrill Gorcunov [this message]
2013-11-15 11:30 ` Cyrill Gorcunov
2013-11-15 11:51 ` Peter Zijlstra
2013-11-15 12:10 ` Cyrill Gorcunov
2013-11-15 12:33 ` Peter Zijlstra
2013-11-15 12:42 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115101946.GG1754@moon \
--to=gorcunov@gmail.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.