All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pv: support ccache builds
Date: Fri, 15 Nov 2013 21:58:27 +0100	[thread overview]
Message-ID: <20131115205827.GI3337@free.fr> (raw)
In-Reply-To: <20131115202856.GA13944@gmail.com>

Andrew, All,

On 2013-11-15 14:28 -0600, Andrew Ruder spake thusly:
> When using ccache TARGET_CC is something like
>     ccache gcc
> 
> This causes problems in the pv build which attempts to
> override LD because the command ends up being
>     make [...] LD=/tools/ccache /tools/gcc LDFLAGS="[...]
> 
> As a result, during the build phase it attempts to build
> /tools/gcc which succeeds by doing nothing:
>     make[1]: Nothing to be done for `/tools/gcc'.
> 
> and during the install phase you get the real build which
> errors out on the LD error this snippet was attempting to
> fix:
>     ld -r -o src/library.o src/library/getopt.o \
>         src/library/gettext.o
>     ld: src/library/gettext.o: Relocations in generic ELF \
>         (EM: 40)
>     src/library/gettext.o: error adding symbols: File in \
>         wrong format
> 
> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  package/pv/pv.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pv/pv.mk b/package/pv/pv.mk
> index 00502d3..5f1a54b 100644
> --- a/package/pv/pv.mk
> +++ b/package/pv/pv.mk
> @@ -17,7 +17,7 @@ PV_LICENSE_FILES = doc/COPYING
>  # the correct one. By passing the below values for LD and LDFLAGS, we
>  # ensure that 'gcc' is used to do these partial linking steps.
>  PV_MAKE_OPT = \
> -	LD=$(TARGET_CC) \
> +	LD="$(TARGET_CC)" \
>  	LDFLAGS="-Wl,-r -nostdlib"
>  
>  $(eval $(autotools-package))

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-11-15 20:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 20:28 [Buildroot] [PATCH] pv: support ccache builds Andrew Ruder
2013-11-15 20:58 ` Yann E. MORIN [this message]
2013-11-17  7:37 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131115205827.GI3337@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.