All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Matt Cowell <matt.cowell@nsn.com>
Cc: ext Thomas Gleixner <tglx@linutronix.de>,
	"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH RT] rtmutex: fix deadlock in spin_trylock
Date: Sat, 16 Nov 2013 14:12:48 +0100	[thread overview]
Message-ID: <20131116131248.GC11518@linutronix.de> (raw)
In-Reply-To: <527AA4FA.2000208@nsn.com>

* Matt Cowell | 2013-11-06 14:22:18 [-0600]:

>I see two ways to fix this:
>1) The way I did in the patch to ensure that spin_trylock never can
>spin on any locks internally.
>2) Converting the timer base lock to a raw_spinlock_t so that it
>actually disables hardirqs in lock_timer_base().  I don't think this
>would be a good idea though.

A third one has been applied where the waiter lock is taken with irqs
off. The thread "CONFIG_NO_HZ_FULL + CONFIG_PREEMPT_RT_FULL = nogo" has
a patch for that.

>
>Thanks,
>-Matt

Sebastian

      reply	other threads:[~2013-11-16 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 15:53 [PATCH RT] rtmutex: fix deadlock in spin_trylock Cowell, Matt (NSN - US/Arlington Heights)
2013-11-06 17:39 ` Thomas Gleixner
2013-11-06 20:22   ` Matt Cowell
2013-11-16 13:12     ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131116131248.GC11518@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=matt.cowell@nsn.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.