From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] nfsd: split up nfsd_setattr
Date: Mon, 18 Nov 2013 06:16:24 -0800 [thread overview]
Message-ID: <20131118141624.GA15744@infradead.org> (raw)
In-Reply-To: <20131118141031.GA3203@fieldses.org>
On Mon, Nov 18, 2013 at 09:10:31AM -0500, J. Bruce Fields wrote:
> On Mon, Nov 18, 2013 at 05:07:30AM -0800, Christoph Hellwig wrote:
> > Split out two helpers to make the code more readable and easier to verify
> > for correctness.
>
> Thanks, both queued up for 2.14.
The write counter leak on a break_lease failure is quite serious,
given that nfsd_break_lease passes O_NONBLOCK and thus remote users
can arbitrarily trigger it.
next prev parent reply other threads:[~2013-11-18 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 13:07 [PATCH 1/2] nfsd: split up nfsd_setattr Christoph Hellwig
2013-11-18 13:07 ` [PATCH 2/2] nfsd: make sure to balance get/put_write_access Christoph Hellwig
2013-11-18 14:10 ` [PATCH 1/2] nfsd: split up nfsd_setattr J. Bruce Fields
2013-11-18 14:16 ` Christoph Hellwig [this message]
2013-11-18 14:39 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118141624.GA15744@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.