From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andreas Dilger <andreas.dilger@intel.com>,
Lai Siyao <lai.siyao@intel.com>
Subject: Re: [PATCH 9/9] staging/lustre/ldlm: fix resource/fid check, use DLDLMRES
Date: Tue, 19 Nov 2013 10:40:53 -0800 [thread overview]
Message-ID: <20131119184053.GA19358@kroah.com> (raw)
In-Reply-To: <1384867428-8395-10-git-send-email-bergwolf@gmail.com>
On Tue, Nov 19, 2013 at 09:23:48PM +0800, Peng Tao wrote:
> From: Andreas Dilger <andreas.dilger@intel.com>
>
> In ll_md_blocking_ast() the FID/resource comparison is incorrectly
> checking for fid_ver() stored in res_id.name[2] instead of name[1]
> changed since http://review.whamcloud.com/2271 (commit 4f91d5161d00)
> landed. This does not impact current clients, since name[2] and
> fid_ver() are always zero, but it could cause problems in the future.
>
> In ldlm_cli_enqueue_fini() use ldlm_res_eq() instead of comparing
> each of the resource fields separately.
>
> Use DLDLMRES/PLDLMRES when printing resource names everywhere.
There are codingstyle warnings in this patch, please fix before
resending.
greg k-h
next prev parent reply other threads:[~2013-11-19 18:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 13:23 [PATCH 0/9] staging/lustre: sync with exernal tree Peng Tao
2013-11-19 13:23 ` [PATCH 1/9] staging/lustre/llite: Access to released file trigs a restore Peng Tao
2013-11-19 18:29 ` Greg Kroah-Hartman
2013-11-20 7:35 ` Peng Tao
2013-11-20 9:40 ` Peng Tao
2013-11-19 13:23 ` [PATCH 2/9] staging/lustre/hsm: Implementation of exclusive open Peng Tao
2013-11-19 13:23 ` [PATCH 3/9] drivers/staging/lustre: indent lustre_ldlm_flags_vals Peng Tao
2013-11-19 13:23 ` [PATCH 4/9] staging/lustre/lnet: Fix assert on empty group in selftest module Peng Tao
2013-11-19 18:37 ` Greg Kroah-Hartman
2013-11-20 9:26 ` Peng Tao
2013-11-20 16:27 ` Greg Kroah-Hartman
2013-11-20 17:34 ` Peng Tao
2013-11-19 13:23 ` [PATCH 5/9] staging/lustre/lnet: coding style fix for lst_test_add_ioctl Peng Tao
2013-11-19 13:23 ` [PATCH 6/9] staging/lustre/lnet: remove extra space in lstcon_rpc_trans_abort Peng Tao
2013-11-19 13:23 ` [PATCH 7/9] staging/lustre/lnet: constify name argument of lstcon_group_find/lstcon_batch_find Peng Tao
2013-11-19 13:23 ` [PATCH 8/9] staging/lustre/lnet: coding style fix for lstcon_test_add Peng Tao
2013-11-19 13:23 ` [PATCH 9/9] staging/lustre/ldlm: fix resource/fid check, use DLDLMRES Peng Tao
2013-11-19 18:40 ` Greg Kroah-Hartman [this message]
2013-11-19 18:41 ` [PATCH 0/9] staging/lustre: sync with exernal tree Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119184053.GA19358@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=lai.siyao@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.